Skip to content

Fixed usage of reserved keywords as column names - #313

Merged
git-hulk merged 3 commits into
AfterShip:masterfrom
blinkzz:master
Aug 12, 2026
Merged

Fixed usage of reserved keywords as column names#313
git-hulk merged 3 commits into
AfterShip:masterfrom
blinkzz:master

Conversation

@blinkzz

@blinkzz blinkzz commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Wanted to thank all contributors for this useful project, keep it up 👍
This PR fixes a few issues that i've encountered while working on internal tool used for table cloning
Both of them were discovered by parsing create_table_query of system.tables:

  • Usage of reserved word for column name
  • Type hint parsing of nested columns, because clickhouse stores a.b[] definition as a.b.:`Array(JSON)`

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac896d84c3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread parser/parser_column.go Outdated
@git-hulk

Copy link
Copy Markdown
Member

@blinkzz Thanks for your fix.

@git-hulk
git-hulk merged commit 96319cb into AfterShip:master Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants