New content: add section on ordinary fixed-point types to Numerics - #1371
Open
gusthoff wants to merge 27 commits into
Open
Conversation
swbaird
reviewed
Jul 6, 2026
swbaird
left a comment
swbaird
left a comment
There was a problem hiding this comment.
Not approving because of check suppression misuse.
Add a comprehensive "Ordinary fixed-point types" section to the "Numerics" chapter of the "Advanced Ada" course.
Also: add admonition about fractional digits.
Move detail into an admonition
gusthoff
force-pushed
the
dev/topic/content/courses/advanced-ada/ordinary-fixed-point-types/2026-06-26
branch
from
July 31, 2026 14:32
fee1419 to
ebbd5ff
Compare
swbaird
previously approved these changes
Jul 31, 2026
swbaird
left a comment
swbaird
left a comment
There was a problem hiding this comment.
Looks good. I particularly like the new Fine_Delta section, and avoiding the use of unsafe check suppression.
swbaird
approved these changes
Aug 7, 2026
swbaird
left a comment
swbaird
left a comment
There was a problem hiding this comment.
One minor point. I'll approve now to let you decide whether a correction is needed.
| its parent type; the only non-obsolescent constraint allowed in a subtype | ||
| declaration is a range constraint. A subtype declaration may also include | ||
| a delta constraint, but, as mentioned above, that's an obsolescent feature. | ||
| its parent type; the only constraint allowed in a subtype declaration is a |
There was a problem hiding this comment.
This sentence is immediately contradicted by the next sentence. Perhaps add a parenthetical "(without using obsolescent language features)" or some similar qualifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.