docs: clarify AFK timeout configuration#173
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cb1d8c6ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| These settings live in ``aw-watcher-afk.toml``, the config file for the ``aw-watcher-afk`` component, not in the ActivityWatch web UI settings page. | ||
| You can open the config folder from the ActivityWatch tray menu, or use the :ref:`config directory <config-directory>` for your platform. |
There was a problem hiding this comment.
Point users to the aw-watcher-afk subdirectory
In the normal aw-qt flow, “Open config folder” opens the ActivityWatch config root, while load_config_toml("aw-watcher-afk", ...) stores this file under the component directory as aw-watcher-afk/aw-watcher-afk.toml. With the current wording, users following these lines will look for aw-watcher-afk.toml directly in the opened folder and may not find it; please include the per-component subdirectory in the path.
Useful? React with 👍 / 👎.
Greptile SummaryThis PR improves discoverability of AFK timeout configuration by adding default values to the existing config reference and adding a new FAQ entry that walks users through editing
Confidence Score: 3/5Documentation-only change that is accurate and well-placed, but omits the restart step that is essential for the config change to take effect. The AFK config FAQ and configuration reference additions are factually correct and the cross-references resolve properly. However, both the FAQ answer and the configuration section direct users to edit a file without telling them that the watcher process must be restarted afterwards. Any user who follows the instructions as written will edit and save the file, see no change in behaviour, and be left without a next step — the exact confusion the PR aims to resolve. src/faq.rst — the new FAQ answer needs a restart instruction before it can fully resolve the user confusion it targets. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User wants to change AFK timeout] --> B[Open ActivityWatch tray menu]
B --> C[Choose 'Open config folder']
C --> D[Navigate to aw-watcher-afk folder]
D --> E[Open aw-watcher-afk.toml]
E --> F{Setting commented out?}
F -- Yes --> G[Remove leading # from timeout line]
F -- No --> H[Edit timeout value directly]
G --> I[Set timeout = desired seconds]
H --> I
I --> J[Save the file]
J --> K[Restart aw-watcher-afk / ActivityWatch]
K --> L[New AFK timeout is active]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User wants to change AFK timeout] --> B[Open ActivityWatch tray menu]
B --> C[Choose 'Open config folder']
C --> D[Navigate to aw-watcher-afk folder]
D --> E[Open aw-watcher-afk.toml]
E --> F{Setting commented out?}
F -- Yes --> G[Remove leading # from timeout line]
F -- No --> H[Edit timeout value directly]
G --> I[Set timeout = desired seconds]
H --> I
I --> J[Save the file]
J --> K[Restart aw-watcher-afk / ActivityWatch]
K --> L[New AFK timeout is active]
Reviews (1): Last reviewed commit: "docs: clarify AFK timeout configuration" | Re-trigger Greptile |
| Yes. The default AFK timeout is 3 minutes. To change it, open the ActivityWatch tray menu, choose the option to open the config folder, then edit the ``aw-watcher-afk`` config file. Set ``timeout`` to the number of seconds without keyboard or mouse activity before ActivityWatch should mark you as AFK. | ||
| For example, ``timeout = 300`` marks you as AFK after 5 minutes. | ||
|
|
||
| The file is named ``aw-watcher-afk.toml``. If the setting is commented out, remove the leading ``#`` before saving. |
There was a problem hiding this comment.
Missing restart instruction after config change
Neither the FAQ answer nor the configuration.rst section mentions that aw-watcher-afk must be restarted for the new timeout value to take effect. A user who edits aw-watcher-afk.toml, saves it, and then resumes working will see no change in behaviour and will likely assume they edited the wrong file or made an error. A one-sentence note — e.g. "After saving the file, restart ActivityWatch (or just the AFK watcher) for the change to take effect." — would close this gap. The same note is absent from the configuration.rst addition.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Addressed the automated feedback in 59fdcf6 by clarifying the |
Summary
aw-watcher-afk.tomlfile and commented default setting behaviortimeoutandpoll_timevalues to the AFK watcher configuration docsContext
This addresses confusion surfaced in ActivityWatch/activitywatch#1288 and related idle/lock-screen questions by making the AFK watcher configuration path discoverable from the FAQ and configuration reference.
Validation
aw-watcher-afk/aw_watcher_afk/config.pyaw_core.config.load_config_tomlgit diff --checkmake SPHINXBUILD=.venv/bin/sphinx-build htmlexits 0; existing upstream/environment warnings remain unrelated to these changed files