refactor(ruff): remove ruff per file exemptions (#2120) by cfxegbert · Pull Request #2139 · AcademySoftwareFoundation/rez

cfxegbert · 2026-06-26T01:34:11Z

Branch summary: `refactor/2120-remove-ruff-per-file-exemptions`

13 commits ahead of main (issue #2120). 16 files changed, +55 / −84 lines.

Goal

Remove most Ruff per-file-ignores and fix the underlying lint issues in code instead of suppressing them globally per file.

Config & CI

ruff.toml: Dropped ~20 per-file ignore entries (tests, bind, resolver, CLI, rezgui, install/setup scripts, etc.). Only one remains:
- src/rezplugins/release_vcs/git.py — F821 (undefined git in export(); uses the git Python package, which isn’t installed — noted as a known bug used by rez-diff / diff_packages.py)
ruff.toml + .github/workflows/ruff.yaml: Exclude src/support/ from Ruff entirely.
src/rez/tests/ruff.toml (new): Extends root config and treats rex builtins (env, command, etc.) as known names in tests.

Code fixes (replacing suppressions)

Area	Change
Type comparisons (E721)	`package_order.py`, `rezgui/objects/Config.py` — use `type(x) is type(y)`
String concatenation (ISC002)	`cli/_main.py` — f-strings instead of implicit concatenation
Unused import (F401)	`ContextToolsWidget.py` — removed unused `app` import; `install.py` — removed unused `virtualenv` import
Lambda assignment (E731)	`TimestampWidget.py` — inline lambda
Undefined names (F821)	`resolver.py` — TYPE_CHECKING imports; `bind/_pymodule.py` — inline `# noqa: F821` on `env`
Ambiguous class (E742)	`test_formatter.py` — inline `# noqa: E742` on class `I`
Import order (E402)	`install.py`, `setup.py`, `release-rez.py` — inline `# noqa: E402`
Datetime (DTZ011)	`release-rez.py` — inline `# noqa: DTZ011` on `date.today()`
Git VCS	`git.py` — added missing `retain_cwd` import (used by `export()`, which `diff_packages.py` calls)

Not in committed changes

diff_packages.py is unchanged on this branch; it’s relevant context because it calls GitReleaseVCS.export(), which is why the git.py F821 exemption remains.

I used some help from an LLM to create the summary for this PR

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…cademySoftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…ftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…ation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…mySoftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…ion#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…ation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

…ion#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

codecov · 2026-06-26T01:36:45Z

Codecov Report

❌ Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.30%. Comparing base (9c1cdee) to head (1706398).

Files with missing lines	Patch %	Lines
src/rez/bind/_pymodule.py	0.00%	3 Missing ⚠️
src/rez/cli/_main.py	0.00%	3 Missing ⚠️
src/rez/package_order.py	71.42%	1 Missing and 1 partial ⚠️
src/rez/resolver.py	0.00%	2 Missing ⚠️
src/rez/config.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
- Coverage   61.31%   61.30%   -0.02%     
==========================================
  Files         164      164              
  Lines       20568    20573       +5     
  Branches     3575     3576       +1     
==========================================
+ Hits        12611    12612       +1     
- Misses       7085     7088       +3     
- Partials      872      873       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JeanChristopheMorinPerso

Let a few comments. Let me know what you think

JeanChristopheMorinPerso · 2026-07-19T10:55:12Z

      - '!src/rez/utils/_version.py'
      - '!src/rez/vendor/**'
      - '!src/rez/data/**'
+      - '!src/support/**'


Umm, support is something we would want to lint eventually...

JeanChristopheMorinPerso · 2026-07-19T10:55:56Z


 def commands() -> None:
-    env.PYTHONPATH.append('{this.root}/python')
+    env.PYTHONPATH.append('{this.root}/python')  # noqa: F821


I would prefer if we use qualified names instead of IDs.

JeanChristopheMorinPerso · 2026-07-19T10:57:41Z

+extend = "../../../ruff.toml"
+
+# Treat rex as builtin 
+builtins = [


This feels "risky" to me. Can we instead use https://github.com/AcademySoftwareFoundation/rez/blob/main/src/rez/utils/lint_helper.py where these are referenced?

JeanChristopheMorinPerso · 2026-07-19T11:00:54Z


    def __eq__(self, other):
-        return type(self) == type(other) and str(self) == str(other)  # noqa: E721
+        if isinstance(other, type(self)):


Are we 100% sure that this will not create a problem? This is different than type() == type(). isinstance will check if an object is an instance of a class or a subclass.

JeanChristopheMorinPerso · 2026-07-19T11:01:27Z


    def __eq__(self, other):
-        return type(self) == type(other)  # noqa: E721
+        return type(self) is type(other)


Why do we use is here while we are using isinstance higher?

JeanChristopheMorinPerso · 2026-07-19T11:02:03Z

-        return type(self) == type(other) and str(self) == str(other)  # noqa: E721
+        if isinstance(other, type(self)):
+            return str(self) == str(other)
+        return NotImplemented


Why return NotImplemented here and not in other classes?

JeanChristopheMorinPerso · 2026-07-19T11:04:53Z

    import venv
 except ImportError:
    USE_VIRTUALENV = True
-    import virtualenv


Should we keep this just to make sure that there's an import failure if it's not installed?

cfxegbert added 13 commits June 25, 2026 16:28

refactor(ruff): get rid of noqa warning (AcademySoftwareFoundation#2120)

5a7212c

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): fix concatenated string literals over multiple lines (A…

636fb4e

…cademySoftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): fix use is and is not for type comparisons (AcademySo…

21149b6

…ftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): fix line too long (AcademySoftwareFoundation#2120)

5f8d441

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): suppress warning in rez-release (AcademySoftwareFound…

6e8a887

…ation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): supress module level import not at top of file (Acade…

bbe1360

…mySoftwareFoundation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): remove unused import (AcademySoftwareFoundation#2120)

9daff76

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): various rezgui fixes (AcademySoftwareFoundation#2120)

5fc63cc

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): add missing import (AcademySoftwareFoundation#2120)

2805862

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

ci(ruff): treat rex a builtin python in tests (AcademySoftwareFoundat…

508ebd3

…ion#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): get rid of some undefined names (AcademySoftwareFound…

f5525ca

…ation#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

refactor(ruff): suppress ambiguous class name (AcademySoftwareFoundat…

ff9215d

…ion#2120) Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

ci: do not use ruff on src/support (AcademySoftwareFoundation#2120)

1706398

Signed-off-by: Robert Minsk <robertminsk@yahoo.com>

cfxegbert requested a review from a team as a code owner June 26, 2026 01:34

cfxegbert changed the title ~~Refactor/2120 remove ruff per file exemptions~~ refactor: remove ruff per file exemptions (#2120) Jun 26, 2026

cfxegbert changed the title ~~refactor: remove ruff per file exemptions (#2120)~~ refactor(ruff): remove ruff per file exemptions (#2120) Jun 29, 2026

JeanChristopheMorinPerso reviewed Jul 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(ruff): remove ruff per file exemptions (#2120)#2139

refactor(ruff): remove ruff per file exemptions (#2120)#2139
cfxegbert wants to merge 13 commits into
AcademySoftwareFoundation:mainfrom
cfxegbert:refactor/2120-remove-ruff-per-file-exemptions

cfxegbert commented Jun 26, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

JeanChristopheMorinPerso left a comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

cfxegbert commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Branch summary: refactor/2120-remove-ruff-per-file-exemptions

Goal

Config & CI

Code fixes (replacing suppressions)

Not in committed changes

Uh oh!

codecov Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cfxegbert commented Jun 26, 2026 •

edited

Loading

Branch summary: `refactor/2120-remove-ruff-per-file-exemptions`

codecov Bot commented Jun 26, 2026 •

edited

Loading