#870 Add support for in-place processing of VRL files with RDWs - #872
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change adds RDW-based variable-length record extraction, supports record lengths that include or exclude headers, updates extractor selection, adds VRL+RDW tests, refreshes ScalaDoc, updates the GPG example, and bumps ScalaTest. ChangesRDW variable-length records
Documentation and test tooling
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🟡 Moderate · up to This PR enables in-place RDW processing but can emit a partial payload or silently drop a record when a file ends before the declared length, potentially corrupting or suppressing records from malformed inputs. Merge should wait for fail-closed handling or explicit owner acceptance of this behavior. Sequence Diagram(s)sequenceDiagram
participant VarLenNestedReader
participant VariableRecordLengthRecordExtractor
participant RecordHeaderParserRDW
participant InputStream
VarLenNestedReader->>VariableRecordLengthRecordExtractor: create extractor for variable-length sequence input
VariableRecordLengthRecordExtractor->>InputStream: read RDW header
VariableRecordLengthRecordExtractor->>RecordHeaderParserRDW: processRdwHeader with byte order and adjustment
RecordHeaderParserRDW-->>VariableRecordLengthRecordExtractor: return record metadata
VariableRecordLengthRecordExtractor->>InputStream: read record payload
VariableRecordLengthRecordExtractor-->>VarLenNestedReader: return buffered payload
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (15 skipped: 15 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JaCoCo code coverage report - 'cobol-parser'
|
JaCoCo code coverage report - 'spark-cobol'
|
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests