Skip to content

Minor refactoring for deploy action - #378

Merged
kevinwallimann merged 2 commits into
masterfrom
fix/deploy-action
Sep 2, 2026
Merged

Minor refactoring for deploy action#378
kevinwallimann merged 2 commits into
masterfrom
fix/deploy-action

Conversation

@kevinwallimann

@kevinwallimann kevinwallimann commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated release automation to handle artifact signing credentials more reliably.
    • Refined publishing configuration for release builds.
    • No changes to application functionality or the end-user experience.

@kevinwallimann kevinwallimann changed the title Fix/deploy action Minor refactoring for deploy action Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0d6216c3-31a4-4418-b273-5d86cee7dbfd

📥 Commits

Reviewing files that changed from the base of the PR and between 915eebe and d1cb9e1.

📒 Files selected for processing (2)
  • .github/workflows/deploy.yml
  • pom.xml
💤 Files with no reviewable changes (1)
  • pom.xml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The deploy workflow now passes PGP_PASSPHRASE as MAVEN_GPG_PASSPHRASE. The Maven deployment profile removes OSSRH repository configuration and its explicit GPG passphrase setting.

Changes

Deployment signing configuration

Layer / File(s) Summary
Update deployment signing configuration
.github/workflows/deploy.yml, pom.xml
The workflow renames the passphrase environment variable to MAVEN_GPG_PASSPHRASE. The Maven deployment profile removes the OSSRH repository block and the explicit GPG passphrase.
Estimated code review effort: 2 (Simple) ~10 minutes

Merge Risk: ⚪ Minimal · up to d1cb9

This PR makes a localized Maven/deploy configuration refactor, including renaming the deployment passphrase environment variable. No actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the build at dawn
The passphrase hops from shell to Maven
Old repository paths fade
Signing settings rest in place
The artifact bounds away

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the deploy action, which is the main area changed. It is broad and does not mention the Maven GPG passphrase fix, but it remains related to the changeset.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

JaCoCo code coverage report

There is no coverage information present for the Files changed

@kevinwallimann
kevinwallimann merged commit 0d9ffb0 into master Sep 2, 2026
7 checks passed
@kevinwallimann
kevinwallimann deleted the fix/deploy-action branch September 2, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant