test: add CI guard for manifest.name parity and global uniqueness (#280) - #288
Open
UroojFatima-052 wants to merge 1 commit into
Open
test: add CI guard for manifest.name parity and global uniqueness (#280)#288UroojFatima-052 wants to merge 1 commit into
UroojFatima-052 wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280
Adds a static YAML scan under
tests/test_registry_identity.pythat runs as part ofpytest tests/in CI. Two independent tests, following the discovery pattern fromtests/test_skill_issuer.py.Changes
tests/test_registry_identity.py(new)test_registry_manifest_name_matches_path, for every registry-layout skill (skills/<category>/<skill_name>/), assertsmanifest.nameequals the path-derived registry ID. Whitespace-only names are treated as missing (strip first). Flat layouts are skipped since_expected_registry_idreturnsNonefor them.test_registry_manifest_names_are_globally_unique, groups skill paths bymanifest.nameusingdefaultdict(list); asserts no name has more than one path. Duplicate failures report both conflicting paths.REPO_ROOTfor readability in CI logs.docs/TESTING.mdtest_registry_identity.pyrow to the Status table.CHANGELOG.md[Unreleased] > Added.Notes
main(2 passed in 0.47s).black --checkandflake8clean.load_skill_by_id(),index.json, or promotingSkillwareIdentityWarningto a hard error.