CI: remove draftversion variables, prepare for release deprecation#446
Merged
Conversation
- Build script now takes optional --finalversion argument. - If finalversion, pdfs are generated with commit hash as version. Else, the version is described as a development version based on the commit hash (also denotes if the repo is clean). - CI always builds as finalversion.
CarolineConcatto
left a comment
CarolineConcatto
left a comment
Contributor
There was a problem hiding this comment.
Are web pages also set to final in this PR?
| # project locally. | ||
| # | ||
| # It accepts one of two options: build or serve. | ||
| # It accepts one mandatory option (build or serve) and one optional one |
Contributor
There was a problem hiding this comment.
Is this sentence correct?It accepts one mandatory option (build or serve) and one optional one (--finalversion).
Contributor
Author
There was a problem hiding this comment.
I don't see a problem
Contributor
Author
|
@CarolineConcatto build_github-pages.sh has the --finalversion mechanism, yes. |
| --- | ||
| title: Arm C Language Extensions | ||
| version: 2026Q1 | ||
| date-of-issue: 15 May 2026 |
CarolineConcatto
approved these changes
Jul 22, 2026
CarolineConcatto
left a comment
CarolineConcatto
left a comment
Contributor
There was a problem hiding this comment.
Thank you Rodolfo,
The changes look good to me.
What @vhscampos thinks about them?
rgwott
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are moving from quarterly ACLE docs releases to rolling releases (on every commit). The draftversion variables do not make sense anymore, let alone the need to maintain them manually for releases. This patch removes them and makes docs/pages refer to the commit hash of the version based on which they were created.
name: Pull request
about: CI reorganization.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
Xthose which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.