[FMV] Add support for more features#444
Open
Lukacma wants to merge 2 commits into
Open
Conversation
|
I think it would make sense to split the "bug fix" part into a separate patch. |
AlfieRichardsArm
left a comment
AlfieRichardsArm
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I think this ought to wait for #441 so this can get its own FMV support version tick
| | sme2p1 | sme2 | | ||
| | sme2p2 | sme2p1 | | ||
| | sve2p1 | sve2 | | ||
| | sve2p2 | sve2p1 | |
Contributor
There was a problem hiding this comment.
Not a bug, but I do wonder
As sve2p2 requires armv9.5 is it worth (for FMV) implying everything thing that armv9.5 implies? That is not something we do for architecture options but it feels like there may be more to loose with FMV as it is more likely to be enabled via target_version (sve2p2) as opposed to -march-armv9.5-a+sve2p2 or -mcpu?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this patch is to propose new features for function multi versioning. This should allow users to use FMV with newer features.
This patch also fixes a bug in register name for SME2 feature register.