Fix hang on exit and build issues on Windows - #105
Open
pschlan-amd wants to merge 2 commits into
Open
pschlan-amd wants to merge 2 commits into
pschlan-amd wants to merge 2 commits into
Conversation
The HRX registry lives in a function-local static, so its destructor runs during DLL_PROCESS_DETACH. On Windows that is after ExitProcess has already killed every other thread, including HSA's, and hrx_gpu_shutdown then hangs in hsa_queue_destroy. Leave device state for the OS on process exit; call hrx_gpu_shutdown from live application code if the process will continue without HRX. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
pschlan-amd
changed the title
pschlan-amd
marked this pull request as ready for review
September 18, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix a few issues discovered on Windows:
Additional information
ggml_backend_hrx_reg_contextnow doesn't clean up after itself anymore and leaves this to the OS. This seems to be the pattern other backends also follow. Since this is owned by the process-lifetime registry, there should be no real leaks coming from this.Requirements