Cherry-pick upstream --log-json - #104
Open
pschlan-amd wants to merge 2 commits into
Open
pschlan-amd wants to merge 2 commits into
pschlan-amd wants to merge 2 commits into
Conversation
pschlan-amd
marked this pull request as ready for review
September 17, 2026 09:11
* common: add --log-jsonl * rename unknown to none
pschlan-amd
force-pushed
the
feat/add-upstream-jsonl
branch
from
September 17, 2026 11:26
ea8986f to
9b2970f
Compare
pschlan-amd
force-pushed
the
feat/add-upstream-jsonl
branch
from
September 17, 2026 11:28
9b2970f to
d26f31e
Compare
Author
|
@jimw567 Do you think we can merge this or alternatively sync with upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR cherry-picks upstream PR ggml-org#28437 to add
--log-json. This makes parsing logs emitted by llama.cpp cleaner.Additional information
Requirements
This is a cherry-pick from the upstream repo and I claim no authorship for the cherry-picked commit.
A small commit had to be placed on top to ensure the change is compiling without pulling in lots of other dependencies from other commits. No AI was used for that change.