fix(ci): enforce post_training isolation in test coordinator and fix missing test markers across test files - #4721
Merged
Conversation
RexBearIU
requested review from
gobbleturk,
khatwanimohit and
shralex
as code owners
August 4, 2026 07:55
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
RexBearIU
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
parambole,
richjames0,
vipannalla and
xibinliu
as code owners
August 4, 2026 07:55
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shralex
approved these changes
Aug 5, 2026
YixuanWang-99
approved these changes
Aug 5, 2026
RexBearIU
force-pushed
the
maxtext-test-marker-isolation
branch
from
August 6, 2026 08:14
4c34f48 to
a606bf5
Compare
…t_training isolation in test coordinator
RexBearIU
force-pushed
the
maxtext-test-marker-isolation
branch
from
August 6, 2026 08:59
a606bf5 to
b6b9589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes leaky test marker expressions in the CI test coordinator and adds missing Pytest markers across 6 test files in MaxText, ensuring pre-training and post-training test suites are strictly isolated and do not accidentally cross-trigger.
Why this change is being made & problem being solved
In
.github/workflows/run_tests_coordinator.yml,tpu-post-training-integrationandtpu7x-post-training-integrationpreviously checked'not cpu_only and not gpu_only and integration_test'. Becauseand post_trainingwas omitted from the filter expression, pre-training integration tests without apost_trainingmark were leaking into the post-training integration test suite. Furthermore, several test files undertests/post_training/andtests/integration/lacked explicit directory/file-level marker declarations (pytestmark = [pytest.mark.post_training],pytestmark = pytest.mark.integration_test), leading to incomplete test suite tagging.Specific implementation details
and post_trainingtotpu-post-training-integrationandtpu7x-post-training-integrationmarker expressions in.github/workflows/run_tests_coordinator.yml.pytestmark = pytest.mark.post_trainingto 3 post-training unit tests:tests/post_training/unit/learn_to_init_test.pytests/post_training/unit/vllm_decode_test.pytests/post_training/unit/vllm_rollout_unroll_test.pypytest.mark.integration_testto 3 integration test files:tests/post_training/integration/grpo_correctness.pytests/integration/check_vma_test.pytests/integration/aot_identical_test.pyuse_sft=Trueinlora_e2e_nnx_test.py) remains markednot post_trainingas it operates on the pre-training engine.not integration_test and not post_training) fortests/unit/without introducing unregistered marker tags that would violate--strict-markersinpytest.ini.Shortcomings & future improvements
In future work, we can consider splitting
tpu-testsinci_pipeline.ymlinto separate matrix jobs for pre-training and post-training suites to enable direct domain-level job gating.Tests
All Required Tests Passed= Success):cpu-unit tests: PASSEDgpu-unit tests: PASSEDtpu-unit tests: PASSEDcpu-post-training-unit tests: PASSEDtpu-post-training-unit tests: PASSEDgpu-integration tests: PASSEDtpu-integration tests: PASSEDmaxtext_tpu_pathways_unit_tests: PASSEDmaxtext_tpu_pathways_integration_tests: PASSED--strict-markerscompliance againstpytest.ini.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.