Update example command lines in the module docstring of train_sft.py to remove weight_dtype=bfloat16 argument; this shouldn't be the default weight_dtype for SFT because of potential loss of gradient updates w/master weights in bfloat16. - #4710
Merged
Conversation
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
vipannalla and
xibinliu
as code owners
August 3, 2026 15:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_958383174
branch
3 times, most recently
from
August 4, 2026 18:39
d0d0b34 to
704728a
Compare
…to remove weight_dtype=bfloat16 argument; this shouldn't be the default weight_dtype for SFT because of potential loss of gradient updates w/master weights in bfloat16. PiperOrigin-RevId: 959272551
copybara-service
Bot
force-pushed
the
test_958383174
branch
from
August 4, 2026 22:49
704728a to
5ae391c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update example command lines in the module docstring of train_sft.py to remove weight_dtype=bfloat16 argument; this shouldn't be the default weight_dtype for SFT because of potential loss of gradient updates w/master weights in bfloat16.