Skip to content

i18n(android): fix format-argument mismatches in 7 locales - #829

Open
owgreen-dev wants to merge 1 commit into
ACINQ:masterfrom
owgreen-dev:fix/i18n-android-format-args
Open

owgreen-dev wants to merge 1 commit into
ACINQ:masterfrom
owgreen-dev:fix/i18n-android-format-args

Conversation

@owgreen-dev

Copy link
Copy Markdown

Two strings.xml resources have format arguments that don't match values/strings.xml, so the runtime getString(id, …) call and the translation disagree.

lnurl_pay_error_invalid_malformed — source is The invoice returned by <b>%1$s</b> is malformed:\n%2$s, but it, ja, ko, pl, uk stop after the first sentence and drop %2$s, so the actual malformed-invoice reason is never shown to those users. Restored the trailing :\n%2$s in each; wording otherwise unchanged.

electrum_dialog_cert_failure — source is Failed to connect (no arguments), but es-419 and pt-BR carry :\n%1$s. Since the string is resolved without arguments, users see a literal %1$s. Dropped the stray argument.

file change
values-it / values-ja / values-ko / values-pl / values-uk lnurl_pay_error_invalid_malformed: append :\n%2$s
values-b+es+419 / values-pt-rBR electrum_dialog_cert_failure: remove :\n%1$s

Found with an open-source i18n checker I maintain (shipi18n) run over the res/ tree; each string was checked by hand against the source. Per TRANSLATION.md I've kept the translations' phrasing and only touched the format arguments — happy to adjust punctuation if a locale prefers something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant