i18n(android): fix format-argument mismatches in 7 locales - #829
Open
owgreen-dev wants to merge 1 commit into
Open
owgreen-dev wants to merge 1 commit into
owgreen-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
strings.xmlresources have format arguments that don't matchvalues/strings.xml, so the runtimegetString(id, …)call and the translation disagree.lnurl_pay_error_invalid_malformed— source isThe invoice returned by <b>%1$s</b> is malformed:\n%2$s, butit,ja,ko,pl,ukstop after the first sentence and drop%2$s, so the actual malformed-invoice reason is never shown to those users. Restored the trailing:\n%2$sin each; wording otherwise unchanged.electrum_dialog_cert_failure— source isFailed to connect(no arguments), butes-419andpt-BRcarry:\n%1$s. Since the string is resolved without arguments, users see a literal%1$s. Dropped the stray argument.lnurl_pay_error_invalid_malformed: append:\n%2$selectrum_dialog_cert_failure: remove:\n%1$sFound with an open-source i18n checker I maintain (shipi18n) run over the
res/tree; each string was checked by hand against the source. Per TRANSLATION.md I've kept the translations' phrasing and only touched the format arguments — happy to adjust punctuation if a locale prefers something else.