Update build to improve release process - #3381
Merged
Merged
Conversation
sstone
force-pushed
the
update-build
branch
2 times, most recently
from
September 17, 2026 14:42
438e0f6 to
bf39f27
Compare
It creates a chicken-and-egg problem if you want to commit the checksum of eclair-core.jar to .mvn/checksums/checksums-workspace.sha256.
To build eclair-fuzz, use the with-eclair-fuzz profile with -Pwith-eclair-fuzz
sstone
force-pushed
the
update-build
branch
from
September 17, 2026 14:44
bf39f27 to
c57ae7c
Compare
Member
Author
|
To validate this PR, check that you can build branch https://github.com/ACINQ/eclair/tree/dummy-release ( |
pm47
reviewed
Sep 17, 2026
pm47
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We update our maven build (some plugins were obsolete) and fix a chicken-and-egg problem in eclair-core's jar manifest to make it compatible with how we manage maven checksums. We can still retrieve and log the commit id as before.