Add fgco2 and volcello to ESM1.6 CMIP7 baseline batch config - #640
Merged
Conversation
Both variables already had working mappings in ACCESS-ESM1-6_mappings.json, but neither was listed in the example batch config, so no CMORisation run ever requested them. Fixes #631
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
=====================================
Coverage 77.2% 77.2%
=====================================
Files 40 40
Lines 8514 8514
Branches 1590 1590
=====================================
Hits 6575 6575
Misses 1610 1610
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Same gap as the example batch config: the production config generator used for CMIP7 fast-track ensemble runs embeds its own copy of the variable list, which was also missing these two variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fgco2andvolcelloalready had correct, working mappings inACCESS-ESM1-6_mappings.json, but neither was listed in any of the places that actually request variables for a CMORisation run, so no run ever produced them.ocnBgchem.fgco2.tavg-u-hxy-sea.mon.glb(→Omon.fgco2) andocean.volcello.tavg-ol-hxy-sea.mon.glb(→Omon.volcello) to:variables:list inbatch_config_esm1-6_cmip7_baseline.yml(example config)CONFIG_TEMPLATEinscripts/generate_configs.py(the generator used to produce real per-experiment batch configs for CMIP7 fast-track ensemble runs — it has its own copy of the variable list and had the same gap)volcellothe samelarge_oceanresource override (256GB mem, 7 cpus) as other full 3D(time, lev, lat, lon)monthly ocean fields likethkcello/thetao, in both files.fgco2is a 2D surface flux (likehfds) and needs no override.Fixes #631
Test plan
ocnBgchem.fgco2.tavg-u-hxy-sea.mon.glbandocean.volcello.tavg-ol-hxy-sea.mon.glbresolve end-to-end via_get_cmip7_to_cmip6_mapping→Omon.fgco2/Omon.volcello,load_model_mappingsfinds each variable inACCESS-ESM1-6_mappings.json, andCMIP7Vocabularyparses the CMOR table for both without error.yaml.safe_loadon both the updated example config and the renderedCONFIG_TEMPLATEconfirms both variables and the new resource override are present in each.fx.areacello_ACCESS-ESM.ncbundled resource file used byvolcello's calculation exists in the package.main(pre-existing localCMIP6Plus_CVssubmodule vocabulary lookup issue, unrelated to this change).🤖 Generated with Claude Code