Skip to content

FIX: Assert at least one matched User-Agent, not exactly one #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandrlazarenko-pi merged 1 commit into from
Jul 23, 2026
+6 −1
Merged

FIX: Assert at least one matched User-Agent, not exactly one #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion fiftyone_devicedetection_onpremise/tests/test_devicedetection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,12 @@ def test_matched_user_agents(self):
fd.process()

self.assertIsInstance(fd.device.useragents.value(), list)
self.assertEqual(len(fd.device.useragents.value()), 1)
# Since the detection result shape was unified in device-detection-cxx
# (issue #362), a single User-Agent produces one result - and so one
# matched User-Agent - per component the engine populates, rather than
# exactly one overall. The number depends on the data file, so assert
# that at least one is returned.
self.assertGreaterEqual(len(fd.device.useragents.value()), 1)

def test_value_types(self):
"""!
Expand Down
Loading