Gameplay tests: fix the inverted camera-measured pitch - #8940
Merged
Conversation
The pitch of a camera view is rotationX - 90, not 90 - rotationX: rotationX is 0 looking straight down (a pitch of -90) and 90 at the horizon, so beyond 90 the view tilts UP. The previous formula had the right magnitude and the wrong sign, so lookTowardWithMouseDelta converged to the mirrored vertical aim (measured: tilted up by exactly the angle it should have tilted down by, in two different games). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaQQdPZ68X8zkybtsxWE1b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pitch of a camera view is
rotationX - 90, not90 - rotationX:rotationXis 0 looking straight down (a pitch of -90) and 90 at the horizon, so beyond 90 the view tilts up. The previous formula had the right magnitude and the wrong sign, solookTowardWithMouseDeltaconverged to the mirrored vertical aim — measured in two different games (FPS: ended atrotationX 93.16, tilted up by exactly the 3.16° it should have tilted down; farming: sweeping down movedpitchDifffurther from zero).getCameraState's documentation is updated to state the convention (rotationX - 90, positive = looking up).Validated: GDJS type-check and build clean, harness karma suite 32/32.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AaQQdPZ68X8zkybtsxWE1b
Generated by Claude Code