Fix possibly-unbound session_token (pylint E0606) - #12
Merged
Merged
Conversation
…a uv in Dockerfile and pylint CI
Finalize uv packaging: remove requirements.txt + MANIFEST, install via uv in Dockerfile and CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-existing pylint
E0606 possibly-used-before-assignmentatokta_auth.pythat turns the pylint CI red onmain.session_tokenwas only assigned inside specificstatusbranches (MFA_REQUIRED,SUCCESS), so if Okta returned any otherstatusvalue the function fell through toreturn session_tokenwith the name unbound — a latentNameError. Initializingsession_token = Nonebefore the branches resolves the lint error and turns that edge case into a defined return instead of a crash.Behavior change
status(none of MFA_REQUIRED/SUCCESS/MFA_ENROLL/LOCKED_OUT), primary auth now returnsNoneinstead of raisingNameError. No change to any handled path.This is the base of the current PR stack (#7 and the rest are stacked on top so CI can go green across the stack).