Prefund faucet operator - #2523
Merged
Merged
Conversation
igamigo
commented
Aug 27, 2026
Comment on lines
+200
to
+206
| // Track all genesis issuance, one entry per faucet account id. A generated faucet operator | ||
| // is pre-funded in `NativeFaucetConfig::build_account`, so account for that allocation | ||
| // before adding configured wallet balances below. | ||
| let mut faucet_issuance = IndexMap::<AccountId, u64>::new(); | ||
| if operator.is_some() { | ||
| faucet_issuance.insert(native_faucet_account_id, DEFAULT_FAUCET_OPERATOR_BALANCE); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This mechanism of tracking faucet issuance predates a lot of the other code, so I'm not sure we still want to do it this way.
Collaborator
There was a problem hiding this comment.
I think its fine for now; the whole genesis code could use some refining imo.
igamigo
marked this pull request as ready for review
August 27, 2026 22:53
Mirko-von-Leipzig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds some token to the faucet operator, and bumps the crate versions.
Changelog