From bc2fa843cd7f2860d2d11921c9e20848f8bf3892 Mon Sep 17 00:00:00 2001 From: Brenden Manquen Date: Wed, 12 Aug 2026 21:52:56 -0500 Subject: [PATCH] fix(ui): use curved arrow for share icon - Replace iOS box-arrow-up glyph, which reads as "upload" off Apple platforms - Apply to Verse of the Day and the verse action popover - Remove now-unused BoxArrowUpIcon --- .changeset/eighty-donkeys-brake.md | 5 ++++ .../ui/src/components/icons/box-arrow-up.tsx | 23 ------------------- packages/ui/src/components/icons/share.tsx | 8 +++---- .../src/components/verse-action-popover.tsx | 4 ++-- 4 files changed, 10 insertions(+), 30 deletions(-) create mode 100644 .changeset/eighty-donkeys-brake.md delete mode 100644 packages/ui/src/components/icons/box-arrow-up.tsx diff --git a/.changeset/eighty-donkeys-brake.md b/.changeset/eighty-donkeys-brake.md new file mode 100644 index 00000000..e904f8dd --- /dev/null +++ b/.changeset/eighty-donkeys-brake.md @@ -0,0 +1,5 @@ +--- +'@youversion/platform-react-ui': patch +--- + +Replace the iOS-style box-arrow-up share glyph with a curved forward arrow in `VerseOfTheDay` and the verse action popover, so the share affordance reads as "share" on non-Apple platforms too. diff --git a/packages/ui/src/components/icons/box-arrow-up.tsx b/packages/ui/src/components/icons/box-arrow-up.tsx deleted file mode 100644 index c1f9bf5c..00000000 --- a/packages/ui/src/components/icons/box-arrow-up.tsx +++ /dev/null @@ -1,23 +0,0 @@ -import type { ComponentProps, ReactElement } from 'react'; - -export function BoxArrowUpIcon(props: ComponentProps<'svg'>): ReactElement { - return ( - - - - - ); -} diff --git a/packages/ui/src/components/icons/share.tsx b/packages/ui/src/components/icons/share.tsx index 8b8f278b..42232307 100644 --- a/packages/ui/src/components/icons/share.tsx +++ b/packages/ui/src/components/icons/share.tsx @@ -11,11 +11,9 @@ const SvgComponent = (props: SVGProps): React.ReactElement => ( > - ); diff --git a/packages/ui/src/components/verse-action-popover.tsx b/packages/ui/src/components/verse-action-popover.tsx index 95197a9e..0d6b5a76 100644 --- a/packages/ui/src/components/verse-action-popover.tsx +++ b/packages/ui/src/components/verse-action-popover.tsx @@ -4,7 +4,7 @@ import { useTranslation } from 'react-i18next'; import i18n from '@/i18n'; import { cn } from '../lib/utils'; import { BoxStackIcon } from './icons/box-stack'; -import { BoxArrowUpIcon } from './icons/box-arrow-up'; +import { Share } from './icons/share'; import { CheckIcon } from './icons/check'; import { buildVerseActionSwatches } from '@/lib/highlight-colors'; import { hexToRgba, HIGHLIGHT_FILL_OPACITY_DARK, isDarkHighlightHex } from './verse'; @@ -439,7 +439,7 @@ export const VerseActionPopover: FC = ({ onClick={onCopy} /> } + icon={} label={t('share')} onClick={onShare} />