Pre-commit hook check doesn't work on suggestions made via the GitHub web UI

[sumau]

The pre-commit hook check doesn't work on suggestions made via the GitHub web UI because it's missing the signed by DBT commit message. See #229 as an example.

See https://ditdigitalteam.slack.com/archives/C0A2MV5BTFY/p1784213847243299 where this was first raised.

Suggestion by @chopkinsmade :

There is an error message about needing to set the GH_TOKEN environment variable, we could try setting that as part of the workflow yaml and see if it fixes it. I'm doubtful it will, so an alternative would be to amend that pre-commit check and try and inspect the incoming params to dect if the source is via the Update button from the PR. We have the check to ignore dependabot commit: if: ${{ github.actor != 'dependabot[bot]' }}

Work-around until issue resolved:

As suggested by @nicopicchio , pull the branch with the suggestions, add an empty commit and push back:

git commit --allow-empty -m "Empty commit to resolve pre-commit hook check error"

[ian-leggett]

GitHub's "Update branch" action generates a merge commit via the GitHub API rather than a local Git client, which means local commit hooks are never executed and the trailer is not added. Since the resulting commit is not associated with an already merged PR, it also falls outside the scope of the current exemption logic.

My proposal

Since we already exempt commits originating from merged PRs, we could apply a similar exemption to merge commits from main. If the merge commit's second parent resolves to origin/main, we can safely bypass the check.

[sumau]

Heya @ian-leggett did you mean to add this comment to this issue or #232? not sure if it will work for suggestions

[ian-leggett]

@sumau sorry I was meant to add the proposal to #232. Thanks