From 84a2fa76b39bd5234c227a881880f06c9e2b461d Mon Sep 17 00:00:00 2001 From: KooshaPari Date: Sat, 12 Sep 2026 23:12:04 -0700 Subject: [PATCH] fix: ValueTracker.evaluate() should not skip falsy values like 0 --- sqlite_utils/utils.py | 2 +- tests/test_utils.py | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/sqlite_utils/utils.py b/sqlite_utils/utils.py index ee6695b55..8be144531 100644 --- a/sqlite_utils/utils.py +++ b/sqlite_utils/utils.py @@ -490,7 +490,7 @@ def guessed_type(self) -> str: return "text" def evaluate(self, value: object) -> None: - if not value or not self.couldbe: + if value is None or not self.couldbe: return not_these: list[str] = [] for name, test in self.couldbe.items(): diff --git a/tests/test_utils.py b/tests/test_utils.py index 360a4436a..6c3c67ee9 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -102,3 +102,27 @@ def test_flatten(input, expected): ) def test_dedupe_keys(input, expected): assert utils.dedupe_keys(input) == expected + + +def test_value_tracker_evaluates_falsy_zero(): + """ValueTracker should evaluate 0 and narrow to integer""" + vt = utils.ValueTracker() + vt.evaluate(0) + vt.evaluate(0) + assert vt.guessed_type == "integer" + + +def test_value_tracker_evaluates_falsy_empty_string(): + """ValueTracker should evaluate empty strings and narrow to text""" + vt = utils.ValueTracker() + vt.evaluate("") + vt.evaluate("") + assert vt.guessed_type == "text" + + +def test_value_tracker_evaluates_falsy_false(): + """ValueTracker should evaluate False and narrow to integer (bool is subclass of int)""" + vt = utils.ValueTracker() + vt.evaluate(False) + vt.evaluate(False) + assert vt.guessed_type == "integer"