ReportDeviceIdResponse shouldn't take data[-1] but data[1]

[pnb990]

il line 213 status is at offest 1 and not -1

[janiversen]

Pull requests are welcome.

[pnb990]

But from which branch I will do m'y pull request?

[janiversen]

Pull requests are always based on dev. please read the README.

[pnb990]

done bug ci not passe CI with code that I have not modified
#2894

[janiversen]

Actually line 213 and 214 should be combined.

[janiversen]

For future reference, data[-1] means the last byte, which according to the standard are status (unless your device have additional data, in which case the status cannot be generically determined). Please read page 31 of the modbus standard.

I assume you wanted this change, because you have a problem, please add a debug log, so we can see what your device actually sends. And open an issue.