Skip to content

AbstractSource::$data is an untyped array, causing mixed-* fallout in downstream analyzers #168

Description

@tyrsson

Context

Found while working phpdb-mysql#60 (mago analyze fixes).

Data

Metadata\Source\AbstractSource::$data is declared protected array $data = []; with no shape (src/Metadata/Source/AbstractSource.php:58). Every keyed read/write against it in downstream sources (e.g. phpdb-mysql's Metadata\Source) resolves to mixed, producing mixed-array-assignment, possibly-invalid-argument, reference-constraint-violation, and too-many-arguments findings in static analysis wherever $data is touched.

@simon-mundy has the most context on this part of the metadata/SQL handling.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions