[Regression] Blank Space on Sidebar

[avivkeller]

Blank space?

[AugustinMauroy]

on git history of doc-kit I don't found something here maybe upstream ?

[avivkeller]

Looks like this also applies to the site, so it's ui-components

[avivkeller]

cc @nodejs/nodejs-website

[avivkeller]

First-known bad: 18cd69c

[avivkeller]

cc @system-conf

[avivkeller]

I assume ml:top-[var(--header-height)] is the culprit?

[system-conf]

Thanks for the bisect and the ping 🙏

Quick context on that commit (#8852): it was fixing #8521, where the last sidebar items were clipped behind the header on scroll. The sidebar was top-0 h-svh — exactly viewport-tall but starting under the header — so the bottom items got hidden. The fix pushed it down and shortened it:

• top-0 → top-[var(--header-height)]
• h-svh → h-[calc(100svh-var(--header-height))]
• dropped the now-redundant pb-[var(--header-height)] on the wrapper

Your guess looks right — top-[var(--header-height)] is the source of the blank space. That offset only makes sense if the header stays pinned over the scroll area. If the header now scrolls away (or the grid already accounts for it), the sticky sidebar ends up parked ~64px (--header-height) below the viewport top, leaving the empty strip in the screenshot.

So this reads like "the offset got re-broken by a later header/layout change" rather than being wrong at the time. Two fixes depending on current header behavior:

• Header no longer overlaps the scroll region → revert to top-0 h-svh (and we may need pb-[var(--header-height)] back to keep Cannot see last item in sidebar after scrolling down, need to scroll down the whole page #8521 fixed).
• Header still overlaps → keep the offset; the gap is likely a double-count of the header height in the grid, which is the thing to hunt down.

Happy to open a PR once we confirm which case we're in — can anyone confirm whether the header is still sticky/pinned on the docs pages?

[avivkeller]

I've opened #9013 to fix it