Skip to content

Clone flow uses default http.Get with no timeout #26

Description

@Jaro-c

I noticed commands/clone.go:506,530,566 all use the default http.Get with no timeout configured — a stalled GitHub response would hang the command indefinitely.

I'd use an http.Client with an explicit timeout, same as what's already done correctly in internal/updater/updater.go:23-24.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions