diff --git a/.github/instructions/ci-workflows.instructions.md b/.github/instructions/ci-workflows.instructions.md index 787350ce..cb99ac23 100644 --- a/.github/instructions/ci-workflows.instructions.md +++ b/.github/instructions/ci-workflows.instructions.md @@ -8,6 +8,4 @@ applyTo: '.github/workflows/*.yml' - When changing validation scope, update the same path set in `validate.yml` `paths` and `validate-patch.yml` `paths-ignore`: the canonical sample catalog, `scripts/**`, `tests/**`, and both npm manifest files. - Preserve the `validate-json-schema` and `test` job names in both validation workflows because the patch workflow supplies their stand-in results. - Keep the Jest `test` job dependent on `validate-json-schema` in `.github/workflows/validate.yml`. -- In the translation handoff, preserve the staging step that collects localized files before opening the cross-repository pull request. -- Reference credentials through GitHub Actions secrets, following `.github/workflows/handover-translations.yml`; never inline credential values. - Get explicit approval before changing triggers, required-check behavior, permissions, secrets, or cross-repository handoff destinations. diff --git a/.github/workflows/handover-translations.yml b/.github/workflows/handover-translations.yml deleted file mode 100644 index 9e153a56..00000000 --- a/.github/workflows/handover-translations.yml +++ /dev/null @@ -1,38 +0,0 @@ -name: Hand over translation files - -on: - push: - branches: - - dev - paths: - - 'messages/**' - - '!messages/GE.json' - - '.github/workflows/handover-translations.yml' - -jobs: - pull-request: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2.3.4 - - - name: Set current date as env variable - run: echo "today=$(date +%Y%m%d%H%M)" >> $GITHUB_ENV - - - name: Create folder - run: | - mkdir -p messages/translated-content && cp messages/GE_* messages/translated-content/ - ls messages/translated-content - - - name: Create pull request to handover translations - uses: paygoc6/action-pull-request-another-repo@v1.0.1 - env: - API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }} - with: - source_folder: 'messages/translated-content/**' - destination_repo: 'microsoftgraph/microsoft-graph-explorer-v4' - destination_folder: 'src/messages' - destination_base_branch: 'dev' - destination_head_branch: chore/handover-translations-${{ env.today }} - user_email: ${{ secrets.ACTION_EMAIL }} - user_name: ${{ secrets.ACTION_USERNAME }} diff --git a/AGENTS.md b/AGENTS.md index 1f21a7b7..49357c21 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -22,7 +22,6 @@ This repository publishes content rather than running an application service. Va > **WARNING:** Production publication and cross-repository handoff are destructive or externally visible operations. Always get explicit user approval before: > - Running or changing the production publication behavior in `azure-pipelines/publishSamples.yml`. -> - Running or changing the translation handoff behavior in `.github/workflows/handover-translations.yml`. > - Changing protected-branch, required-check, credential, or secret handling. ### Rules @@ -35,8 +34,6 @@ This repository publishes content rather than running an application service. Va ## Secrets Management -GitHub Actions accesses credentials through repository secrets in `.github/workflows/handover-translations.yml`, including `API_TOKEN_GITHUB`, `ACTION_EMAIL`, and `ACTION_USERNAME`. - ### Rules for AI Agents - Never inline secrets, tokens, passwords, connection strings, certificate material, or secret values. diff --git a/repo-context.md b/repo-context.md index 4d2043df..81647bd4 100644 --- a/repo-context.md +++ b/repo-context.md @@ -73,8 +73,7 @@ The repository follows a content pipeline rather than an application service lay 2. `tests/samples.schema.json` and the Jest specifications under `tests/` validate the sample-query and permission content through `scripts/test-initiator.js`. 3. `.github/workflows/validate.yml` runs schema validation and the npm test suite for relevant pull requests and pushes. 4. `azure-pipelines/publishSamples.yml` packages sample-query and permission files and uploads them to Azure Blob Storage from `master`. -5. `.github/workflows/handover-translations.yml` copies translated `messages/GE_*` files to `microsoftgraph/microsoft-graph-explorer-v4` from the `dev` branch. -6. The DevX API and Graph Explorer consume the published content, as described in `README.md`. +5. The DevX API and Graph Explorer consume the published content, as described in `README.md`. --- @@ -83,7 +82,7 @@ The repository follows a content pipeline rather than an application service lay - The unsuffixed JSON file is the base content file, such as `GE.json`, `sample-queries.json`, or `permissions-descriptions.json`. - Localized files append an underscore and locale code before `.json`, such as `_de-DE`, `_fr-FR`, or `_zh-CN`. - Jest test files use the `.spec.js` suffix. -- GitHub workflow file names describe their action, such as `validate.yml`, `validate-patch.yml`, and `handover-translations.yml`. +- GitHub workflow file names describe their action, such as `validate.yml` and `validate-patch.yml`. --- @@ -93,14 +92,14 @@ The repository follows a content pipeline rather than an application service lay |--------|------|-----------|-------| | Content catalogs | JSON documents | `sample-queries/sample-queries.json`, `permissions/permissions-descriptions.json`, `permissions/new/permissions.json`, `permissions/new/provisioningInfo.json`, `messages/GE.json`, `ge-tour/tour-steps.json` | Canonical and localized data consumed outside this repository. | | Validation configuration | npm script and JSON Schema | `package.json`, `tests/samples.schema.json`, `scripts/test-initiator.js` | `npm run test` starts Jest; GitHub Actions separately validates the sample catalog against its schema. | -| GitHub automation | GitHub Actions YAML | `.github/workflows/validate.yml`, `.github/workflows/validate-patch.yml`, `.github/workflows/handover-translations.yml` | Path filters select validation or translation handoff behavior. | +| GitHub automation | GitHub Actions YAML | `.github/workflows/validate.yml`, `.github/workflows/validate-patch.yml` | Path filters select validation behavior. | | Publication automation | Azure Pipelines YAML | `azure-pipelines/publishSamples.yml` | Packages sample-query and permission content and publishes it to Azure Blob Storage. | | Branch governance | Repository policy YAML and CODEOWNERS | `.github/policies/microsoft-graph-devx-content-branch-protection.yml`, `.github/CODEOWNERS` | Protects `master` and `dev` and assigns repository-wide ownership. | ### Config Disambiguation - `package.json` defines the local test command and development dependencies; `tests/samples.schema.json` defines the allowed shape of sample-query content. -- GitHub Actions validate pull requests and hand off translations; `azure-pipelines/publishSamples.yml` handles production artifact publication. +- GitHub Actions validate pull requests; `azure-pipelines/publishSamples.yml` handles production artifact publication. --- @@ -112,7 +111,6 @@ The repository follows a content pipeline rather than an application service lay - `tests/permissions-descriptions.spec.js` - checks display-name formatting in the canonical permission descriptions. - `.github/workflows/validate.yml` - CI entry point for schema and Jest validation. - `azure-pipelines/publishSamples.yml` - production publication entry point for sample-query and permission files. -- `.github/workflows/handover-translations.yml` - translation handoff entry point for localized Graph Explorer messages. --- @@ -135,12 +133,6 @@ The repository follows a content pipeline rather than an application service lay | Azure Blob Storage | Receives published sample-query and permission artifacts from the production pipeline. | Not declared in this repository | | Microsoft Graph documentation endpoints | Supply the `docLink` targets checked by the sample validation suite. | Not declared in this repository | -### Related Repositories - -| Repo | Relationship | Purpose | -|------|-------------|---------| -| `microsoftgraph/microsoft-graph-explorer-v4` | Receives translated message files through `.github/workflows/handover-translations.yml`. | Hosts the Graph Explorer application that consumes the content. | - --- ## Team Ownership