Windows: fatal error C1001: An internal error has occurred in the compiler.

[wilhelmberg]

mapnik@master and node-mapnik@master as of now.

 c:\mb\windows-builds-64\packages\node-mapnik\mapnik-sdk\include\mapnik/symbolizer_base.hpp(104): note: see reference to function
   template instantiation 'mapnik::util::variant<mapnik::value_bool,mapnik::value_integer,mapnik::enumeration_wrapper,mapnik::valu
  e_double,std::string,mapnik::color,mapnik::expression_ptr,mapnik::path_expression_ptr,mapnik::transform_type,mapnik::text_placem
  ents_ptr,mapnik::dash_array,mapnik::raster_colorizer_ptr,mapnik::group_symbolizer_properties_ptr,mapnik::font_feature_settings>:
  :variant<const char*&,mapbox::util::detail::value_traits<T,mapnik::value_bool,mapnik::value_integer,mapnik::enumeration_wrapper,
  mapnik::value_double,std::string,mapnik::color,mapnik::expression_ptr,mapnik::path_expression_ptr,mapnik::transform_type,mapnik:
  :text_placements_ptr,mapnik::dash_array,mapnik::raster_colorizer_ptr,mapnik::group_symbolizer_properties_ptr,mapnik::font_featur
  e_settings>,void>(const char *&) noexcept' being compiled
          with
          [
              T=const char *&
          ] (compiling source file ..\src\mapnik_map.cpp)
..\src\mapnik_vector_tile.cpp(2706): warning C4101: 'ex': unreferenced local variable [c:\mb\windows-builds-64\packages\node-mapni k\build\mapnik.vcxproj]
..\src\mapnik_vector_tile.cpp(3650): fatal error C1001: An internal error has occurred in the compiler. [c:\mb\windows-builds-64\p ackages\node-mapnik\build\mapnik.vcxproj]
  (compiler file 'msc1.cpp', line 1421)
   To work around this problem, try simplifying or changing the program near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information
  ..\src\mapnik_vector_tile.cpp(3650): note: while compiling class template member function 'mapnik::util::variant<Image *,CairoSu
  rface *,Grid *>::variant<nullptr,mapbox::util::detail::value_traits<T,Image *,CairoSurface *,Grid *>,void>(nullptr &&) noexcept(
  <expr>)'
          with
          [
              T=nullptr
          ]
  Internal Compiler Error in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\CL.exe.  You will be prompted to sen
  d an error report to Microsoft later.
  INTERNAL COMPILER ERROR in 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\CL.exe'
      Please choose the Technical Support command on the Visual C++
      Help menu, or open the Technical Support help file for more information
cl : Command line error D8040: error creating or communicating with child process [c:\mb\windows-builds-64\packages\node-mapnik\bu ild\mapnik.vcxproj]

Possible hints:

• optimization settings with VS2015 Update 1:
  https://social.msdn.microsoft.com/Forums/vstudio/en-US/ea74ee2b-3c8b-4b55-ab0b-9ec5d6f9acef/compiler-bug-in-vs-2015-when-using-code-analyzer-on-kernel-driver-c-code-project?forum=vsdebug
  https://msdn.microsoft.com/en-us/library/y19zxzb2.aspx?f=255&MSPPError=-2147217396
  https://connect.microsoft.com/VisualStudio/feedback/details/813086/c1xx-fatal-error-c1001-an-internal-error-has-occurred-in-the-compiler
• compiler out of heap memory
  https://support.microsoft.com/en-us/kb/195738

[wilhelmberg]

Doesn't seem to be the optimization.

Currently we don't have optimization specified explicitly, but tried with

• 0: off
• 2: speed
• 3: full

same error.

[lightmare]

Alas, more ICE! I'd try this to make it easier for the compiler:

• change void to something else here: https://github.com/mapbox/variant/blob/5aab5df0dc899b484c04ce9c649645787ee0bc5c/variant.hpp#L127 -- maybe it doesn't like void in tuple, you can change it any other type, it's not used
• if that doesn't help, remove noexcept here: https://github.com/mapbox/variant/blob/5aab5df0dc899b484c04ce9c649645787ee0bc5c/variant.hpp#L589 -- in case it has trouble with is_nothrow_constructible
• I'd also check whether is_same, is_convertible work well with nullptr_t

[springmeyer]

@BergWerkGIS - I just looked into this a bit. I'm feeling like the use of mapbox::variant here is not mandatory. If this is the only place this compiler problem is happening we could workaround by using raw pointers and dropping variant usage. Of course that would just dodge the problem and it is likely worth fully fixing in variant - just really hard to do that given we'd need to reduce a testcase for what is happening and what is happening is a compiler crash not a clear code error.

So I think the best route here is to troubleshoot this in node-mapnik. Could you create a branch of node-mapnik that points at a Mapnik master SDK then ping me? I'll then poke by committing to that branch and letting appveyor tell me if we've dodged the issue.

[springmeyer]

Could you create a branch of node-mapnik that points at a Mapnik master SDK then ping me?

@BergWerkGIS - nevermind! I got this and bumped to start testing in 238035e

[springmeyer]

That commit passed: 238035e. I assumed it would fail and the original compiler error would be replicated. Not sure why not....

[springmeyer]

@BergWerkGIS - let me know when you've had a chance to test to see if you can still replicate this.

[wilhelmberg]

@springmeyer sorry, forgot to report back yesterday.

Tried again today on three different machines.

Built all deps, mapnik and node-mapnik from scratch.

Interestingly node-mapnik fails on all of them when using the locally created mapnik SDK.
Also tried node@0.10.40/0.12.7/5.1.0 -> all fail.

However, if I use mapnik-win-sdk-v3.0.9-246-gd751731-x64-14.0.7z (created 3 days ago by the same scripts), which also gets pulled in by AppVeyor, the build succeeds.

---

My current hunch: Visual Studio 2015 Update 1 which I have installed on all local machines but neither on our build server nor on AppVeyor.

Maybe Update 1 creates a mapnik SDK that does work on its own but not in conjunction with node-mapnik (clash of some optimization or other settings???).

Also interesting that Visual Studio 2015 Update 1 is able to build node-mapnik with a mapnik SDK created by stock Visual Studio 2015.

[wilhelmberg]

Could this be why node-mapnik is failing to build on Windows and that VS is unable to determine dependent names apart from non-dependent names?

Partial Support for Expression SFINAE in VS 2015 Update 1

Especially the "unsupported section".

[lightmare]

Can you confirm that the error is not caused by initializing the variant with nullptr?

Regardless of the above, I think this is where no_init might actually be useful. But for that to work, visitation of uninitialized variant would have to do something other than attempt (and fail) to visit the last alternative. I'll submit an issue at variant.

[springmeyer]

@lightmare - good clues.

@BergWerkGIS - you were going to diff out the differences in the Mapnik SDK that crashes vs not - what was the outcome of that investigation?

Also @BergWerkGIS @artemp will ping you in the morning to try debugging interactively with a few ideas that might help.

[artemp]

Here is my rough plan to try tomorrow with @BergWerkGIS :

• First thing first - Lets get a diff to see if code is different between local build and AppVeyor
  /cc @BergWerkGIS ^.
• Second - lets try something like this to avoid initialising variant with nullptr

struct dummy {};
using surface_type = mapnik::util::variant<
    dummy,
    Image *
  , CairoSurface *
#if defined(GRID_RENDERER)
  , Grid *
#endif
  >;

In vector_tile_render_baton_t constructor replace surface(nullptr) with surface() + amend struct deref_visitor

• Third - storing raw pointers in variant doesn't look like a good idea anyways

[wilhelmberg]

Diff: Not exactly sure how that happened, but old variant made it into the SDK that already should have contained a new one.

• SDK that worked: variant@0.1.0
• SDK that fails: variant@1.1.0

I updated the build chain with a new SDK.
Now AppVeyor fails with the same error:

 ..\src\mapnik_vector_tile.cpp(3650): note: while compiling class template member function 'mapnik::util::variant<Image *,CairoSurface *,Grid *>::variant<nullptr,mapbox::util::detail::value_traits<T,Image *,CairoSurface *,Grid *>,void>(nullptr &&) noexcept(<expr>)'
          with
          [
              T=nullptr
          ]
  Internal Compiler Error in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\CL.exe.  You will be prompted to send an error report to Microsoft later.
cl : Command line error D8040: error creating or communicating with child process [C:\projects\node-mapnik\build\mapnik.vcxproj]

https://ci.appveyor.com/project/Mapbox/node-mapnik/build/1.0.1242/job/m3n76h4mg5oqinjp#L405