Skip to content

Commit 71342e8

Browse files
committed
docs(gooddata-eval): drop the kda_skill cross-reference from _extract_metric_result
Confusing to a reviewer with no KDA context; the relevant fact is that conversation.py now shares this implementation instead of its own copy. JIRA: QA-29053 risk: nonprod
1 parent 73fcc7a commit 71342e8

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/gooddata-eval/src/gooddata_eval/core/agentic/metric_skill.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,8 @@ def _extract_metric_result(tool_call_events: list[ToolCallEvent]) -> dict | None
166166
"""Result payload of the create_metric tool call.
167167
168168
Prefers the most recent successful call in this turn -- when the agent retries
169-
after a validation error, the earlier failed attempt must not shadow it. Mirrors
170-
the "last wins" pairing in ``kda_skill._extract_kda_calls``.
169+
after a validation error, the earlier failed attempt must not shadow it. Shared
170+
with ``conversation.py``, which imports this instead of keeping its own copy.
171171
"""
172172
for tc in reversed(tool_call_events):
173173
if tc.function_name != "create_metric" or not tc.result:

packages/gooddata-eval/tests/test_agentic_metric_skill.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_extract_metric_result_skips_a_failed_call_after_an_earlier_success():
5151

5252
def test_extract_metric_result_prefers_the_most_recent_successful_call():
5353
"""Two distinct successful create_metric calls in one turn (not a retry after a
54-
failure) -- the later one wins, consistent with kda_skill's 'last pair' rule."""
54+
failure) -- the later one wins."""
5555
calls = [
5656
_create_metric_call('{"data": {"metric_id": "m1"}}'),
5757
_create_metric_call('{"data": {"metric_id": "m2"}}'),

0 commit comments

Comments
 (0)