Commit 53dc5d2
committed
docs(eval): clarify _args_match comments per review
Address review nits on search_tool _args_match:
- reword _normalize_str_list comment: dropping non-string entries prevents
a crash, it does not force a mismatch (surviving strings still compare)
- note that object_types is compared case-sensitively on purpose (controlled
ObjectType StrEnum values emitted verbatim)
No behavior change. keywords/object_types are declared list[str] in the
search_objects schema, so string-collapse false-negatives cannot occur.
JIRA: TRIVIAL
risk: nonprod1 parent f847679 commit 53dc5d2
1 file changed
Lines changed: 9 additions & 3 deletions
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| |||
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
| |||
0 commit comments