Merge pull request #1770 from gooddata/snapshot-master-12861e2b-to-rel/dev

[bot] Merge master/12861e2b into rel/dev

Author: yenkins-admin

.github/workflows/rw-python-tests.yaml

@@ -44,6 +44,9 @@ jobs:
       - name: pep8 and formatting check
         run: |
           make format
+      - name: lint check
+        run: |
+          make lint
   docs-scripts-tests:
     runs-on: ubuntu-latest
     if: ${{inputs.changed-python-modules == 'true'}}

.pre-commit-config.yaml

@@ -15,7 +15,7 @@ repos:
         args: [ '--maxkb=890' ]
       - id: check-case-conflict
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.15.1
+    rev: v0.15.20
     hooks:
       # Run the linter.
       - id: ruff

Dockerfile

@@ -1,6 +1,6 @@
 # (C) 2021 GoodData Corporation
 ARG PY_TAG
-FROM ghcr.io/astral-sh/uv:0.12 AS uv
+FROM ghcr.io/astral-sh/uv:0.12.5 AS uv
 FROM python:${PY_TAG}
 
 ARG PY_TAG
@@ -40,16 +40,35 @@ WORKDIR /data
 COPY pyproject.toml uv.lock ./
 
 # Install tox and tox-uv as system packages so they're available globally.
-# NOTE: `uv pip install --group` reads the group's requirements from pyproject.toml but
-# resolves them FRESH from the index -- it does NOT read uv.lock. Every version that must
-# stay fixed therefore needs an explicit bound in the group itself; in particular `uv`,
-# whose console script installs over the binary copied above.
+# Via `uv export` and not `uv pip install --group`: the latter re-resolves fresh from the
+# index, while export reads uv.lock, so the image gets exactly the pinned versions.
+# The group uses tox-uv-bare, so nothing here installs a `uv` console script over the
+# binary COPYed above -- that COPY is the image's only uv, hence its exact pin.
 # Clean up dependency files after installation to reduce image size
 RUN set -x \
-  && uv pip install --system --group tox \
-  && rm -f pyproject.toml uv.lock \
+  && uv export --frozen --only-group tox -o /tmp/tox-requirements.txt \
+  && uv pip install --system -r /tmp/tox-requirements.txt \
+  && rm -f pyproject.toml uv.lock /tmp/tox-requirements.txt \
   && true
 
+# Any uv command here must not REWRITE the bind-mounted host uv.lock if it thinks it is
+# stale -- fail instead. Not UV_FROZEN: tox-uv reads that and downgrades its own --locked
+# to --frozen, silently accepting a stale lock. Must be set AFTER the export above, which
+# is rejected in combination with UV_LOCKED and has to stay --frozen because only the root
+# pyproject.toml and uv.lock exist at that layer for --locked to validate against.
+ENV UV_LOCKED=1
+
+# Use the lock-pinned tox installed system-wide above rather than project_common.mk's
+# default `uv run tox`, which would first sync the whole workspace into a throwaway
+# in-container project env (measured: 58 packages, ~7s) just to obtain the same tox.
+ENV TOX=tox
+
+# The repo is bind-mounted at /data, so the default project environment (/data/.venv) is
+# the developer's host venv; a `uv run` here would rebuild it against this image's Linux
+# interpreter. Redirect it somewhere container-local (/tmp, not a home dir: the runtime
+# user is created by entrypoint.sh, so no home exists when this ENV is evaluated).
+ENV UV_PROJECT_ENVIRONMENT=/tmp/uv-project-venv
+
 COPY .docker/entrypoint.sh /entrypoint.sh
 
 LABEL image_name="GoodData Python SDK test image with python, tox and make"

Makefile

@@ -104,13 +104,13 @@ test-staging:
 clean-staging:
 	@test -n "$(STAGING_ADMIN_TOKEN)" || (echo "ERROR: STAGING_ADMIN_TOKEN is required. Set it in .env or pass on CLI." && exit 1)
 	@test -n "$(STAGING_DS_PASSWORD)" || (echo "ERROR: STAGING_DS_PASSWORD is required. Set it in .env or pass on CLI." && exit 1)
-	cd packages/tests-support && STAGING=1 TOKEN="$(STAGING_ADMIN_TOKEN)" DS_PASSWORD="$(STAGING_DS_PASSWORD)" python clean_staging.py
+	cd packages/tests-support && STAGING=1 TOKEN="$(STAGING_ADMIN_TOKEN)" DS_PASSWORD="$(STAGING_DS_PASSWORD)" uv run --locked python clean_staging.py
 
 .PHONY: load-staging
 load-staging:
 	@test -n "$(STAGING_ADMIN_TOKEN)" || (echo "ERROR: STAGING_ADMIN_TOKEN is required. Set it in .env or pass on CLI." && exit 1)
 	@test -n "$(STAGING_DS_PASSWORD)" || (echo "ERROR: STAGING_DS_PASSWORD is required. Set it in .env or pass on CLI." && exit 1)
-	cd packages/tests-support && STAGING=1 TOKEN="$(STAGING_ADMIN_TOKEN)" DS_PASSWORD="$(STAGING_DS_PASSWORD)" python upload_demo_layout.py
+	cd packages/tests-support && STAGING=1 TOKEN="$(STAGING_ADMIN_TOKEN)" DS_PASSWORD="$(STAGING_DS_PASSWORD)" uv run --locked python upload_demo_layout.py
 
 .PHONY: release
 release:

packages/gooddata-dbt/tox.ini

@@ -5,7 +5,6 @@ envlist = py3{10,11,12,13,14}
 [testenv]
 runner = uv-venv-lock-runner
 package = wheel
-wheel_build_env = .pkg
 dependency_groups =
     test
 setenv =

packages/gooddata-eval/.gitignore

@@ -0,0 +1,8 @@
+# (C) 2026 GoodData Corporation
+
+# Unit test / coverage reports
+.tox/
+.coverage
+.coverage.*
+coverage.xml
+.json-report-*.json

packages/gooddata-eval/src/gooddata_eval/core/chat/sse_client.py

@@ -89,13 +89,11 @@ def _is_retryable_exc(exc: Exception) -> bool:
         return True
     if isinstance(exc, httpx.HTTPStatusError):
         return exc.response.status_code in _RETRYABLE_STATUS_CODES
-    if isinstance(exc, httpx.RemoteProtocolError):
-        # Mid-stream disconnect ("peer closed connection without sending complete
-        # message body") -- pure network flake, not a real agent/content failure.
-        # Confirmed live: contaminated ~1-4% of visualization runs with a hard
-        # fail and zero retry attempts.
-        return True
-    return False
+    # Mid-stream disconnect ("peer closed connection without sending complete
+    # message body") -- pure network flake, not a real agent/content failure.
+    # Confirmed live: contaminated ~1-4% of visualization runs with a hard
+    # fail and zero retry attempts.
+    return isinstance(exc, httpx.RemoteProtocolError)
 
 
 def _retry_transient(operation: Callable[[], T], *, is_retryable: Callable[[Exception], bool]) -> T:

packages/gooddata-eval/tests/test_agentic_runner.py

@@ -3,7 +3,7 @@
 from unittest.mock import patch
 
 import pytest
-from gooddata_eval.cli.agentic_runner import _dispatch_agentic, run_agentic_items
+from gooddata_eval.cli.agentic_runner import AGENTIC_TEST_KINDS, _dispatch_agentic, run_agentic_items
 from gooddata_eval.core.agentic.alert_skill import AlertSkillAssertionError
 from gooddata_eval.core.models import AgenticEvalOutcome, DatasetItem
 
@@ -81,8 +81,6 @@ def test_all_agentic_kind_cases_covers_every_registered_kind():
     """Guards the two parametrized tests below against silently going stale: a kind added
     to AGENTIC_TEST_KINDS without a matching case here would otherwise just not get tested,
     not fail loudly."""
-    from gooddata_eval.cli.agentic_runner import AGENTIC_TEST_KINDS
-
     covered = {kind for kind, _, _ in _ALL_AGENTIC_KIND_CASES}
     assert covered == set(AGENTIC_TEST_KINDS)
 
@@ -194,8 +192,6 @@ def test_dispatch_agentic_returns_a_real_outcome_for_every_kind(kind, expected_o
     evaluator produced -- not None, not the outcome's reasoning_steps list alone, not any
     other bare value the old `isinstance(outcome, tuple)`/`isinstance(outcome, AgenticEvalOutcome)`
     fallback could silently swallow."""
-    from gooddata_eval.core.models import AgenticEvalOutcome
-
     item = DatasetItem(
         id="q1",
         dataset_name="ds",

packages/gooddata-eval/tox.ini

@@ -5,7 +5,6 @@ envlist = py3{10,11,12,13,14}
 [testenv]
 runner = uv-venv-lock-runner
 package = wheel
-wheel_build_env = .pkg
 extras =
     llm-judge
 dependency_groups =

packages/gooddata-fdw/tox.ini

@@ -5,7 +5,6 @@ envlist = py3{10,11,12,13,14}
 [testenv]
 runner = uv-venv-lock-runner
 package = wheel
-wheel_build_env = .pkg
 dependency_groups =
     test
 setenv =