C#: Address review comments.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNetCliInvoker.cs

@@ -46,7 +46,7 @@ private ProcessStartInfo MakeDotnetStartInfo(List<string> args, string? workingD
             // Configure the proxy settings, if applicable.
             if (this.proxy != null)
             {
-                logger.LogDebug($"Configuring environment variables for the Registry proxy at {this.proxy.Address}");
+                logger.LogDebug($"Configuring environment variables for the registry proxy at {this.proxy.Address}");
 
                 startInfo.EnvironmentVariables["HTTP_PROXY"] = this.proxy.Address;
                 startInfo.EnvironmentVariables["HTTPS_PROXY"] = this.proxy.Address;

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/EnvironmentVariableNames.cs

@@ -75,17 +75,17 @@ internal static class EnvironmentVariableNames
         public const string DiagnosticDir = "CODEQL_EXTRACTOR_CSHARP_DIAGNOSTIC_DIR";
 
         /// <summary>
-        /// Specifies the hostname of the Registry proxy.
+        /// Specifies the hostname of the registry proxy.
         /// </summary>
         public const string ProxyHost = "CODEQL_PROXY_HOST";
 
         /// <summary>
-        /// Specifies the port of the Registry proxy.
+        /// Specifies the port of the registry proxy.
         /// </summary>
         public const string ProxyPort = "CODEQL_PROXY_PORT";
 
         /// <summary>
-        /// Contains the certificate used by the Registry proxy.
+        /// Contains the certificate used by the registry proxy.
         /// </summary>
         public const string ProxyCertificate = "CODEQL_PROXY_CA_CERTIFICATE";
 

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManagerIO.cs

@@ -43,7 +43,7 @@ public bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount)
         {
             logger.LogInfo($"Checking if NuGet feed '{feed}' is reachable...");
 
-            // Configure the HttpClient to be aware of the Registry proxy, if used.
+            // Configure the HttpClient to be aware of the registry proxy, if used.
             HttpClientHandler httpClientHandler = new();
             if (registryProxy != null)
             {

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/IRegistryProxy.cs

@@ -7,7 +7,7 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
     public interface IRegistryProxy : IDisposable
     {
         /// <summary>
-        /// The full address of the Registry proxy, if available.
+        /// The full address of the registry proxy, if available.
         /// </summary>
         string Address { get; }
 
@@ -27,7 +27,7 @@ public interface IRegistryProxy : IDisposable
         string? CertificatePath { get; }
 
         /// <summary>
-        /// The certificate used for the Registry proxy.
+        /// The certificate used for the registry proxy.
         /// </summary>
         X509Certificate2? Certificate { get; }
     }

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/IRegistryProxyConfiguration.cs

@@ -4,16 +4,16 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
 {
     public interface IRegistryProxyConfiguration
     {
-        // The host of the Registry proxy, if available.
+        // The host of the registry proxy, if available.
         string? Host { get; }
 
-        // The port of the Registry proxy, if available.
+        // The port of the registry proxy, if available.
         string? Port { get; }
 
-        // The certificate of the Registry proxy, if available.
+        // The certificate of the registry proxy, if available.
         string? Certificate { get; }
 
-        // The list of package registries that are configured for the Registry proxy, if any.
+        // The list of package registries that are configured for the registry proxy, if any.
         // The value of the environment variable should be a JSON array of objects, such as:
         // [ { "type": "nuget_feed", "url": "https://nuget.pkg.github.com/org/index.json" } ]
         string? RegistryURLs { get; }

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/RegistryProxy.cs

@@ -81,7 +81,7 @@ private RegistryProxy(IRegistryProxyConfiguration config, ILogger logger, Tempor
                 writer.Write(config.Certificate);
                 writer.Close();
 
-                logger.LogInfo($"Stored Registry proxy certificate at {CertificatePath}");
+                logger.LogInfo($"Stored registry proxy certificate at {CertificatePath}");
 
                 Certificate = X509Certificate2.CreateFromPem(config.Certificate);
             }
@@ -130,7 +130,7 @@ private RegistryProxy(IRegistryProxyConfiguration config, ILogger logger, Tempor
         internal static IRegistryProxy? Make(ILogger logger, IDiagnosticsWriter diagnosticsWriter, TemporaryDirectory tempWorkingDirectory)
         {
             // Setting HTTP(S)_PROXY and SSL_CERT_FILE have no effect on Windows or macOS,
-            // but we would still end up using the Registry proxy to check for feed reachability.
+            // but we would still end up using the registry proxy to check for feed reachability.
             // This would result in us discovering that the feeds are reachable, but `dotnet` would
             // fail to connect to them. To prevent this from happening, we do not initialise an
             // instance of `RegistryProxy` on those platforms.
@@ -143,7 +143,7 @@ private RegistryProxy(IRegistryProxyConfiguration config, ILogger logger, Tempor
         }
 
         /// <summary>
-        /// Creates an instance of the Registry proxy using the specified configuration.
+        /// Creates an instance of the registry proxy using the specified configuration.
         /// Returns null if the proxy cannot be created.
         /// This overload is exposed primarily to enable platform-independent unit testing.
         /// </summary>
@@ -152,7 +152,7 @@ private RegistryProxy(IRegistryProxyConfiguration config, ILogger logger, Tempor
         {
             if (string.IsNullOrWhiteSpace(proxyConfig.Host) || string.IsNullOrWhiteSpace(proxyConfig.Port))
             {
-                logger.LogDebug("No Registry proxy credentials are configured.");
+                logger.LogDebug("No registry proxy credentials are configured.");
                 return null;
             }
 

csharp/extractor/Semmle.Extraction.Tests/RegistryProxy.cs

@@ -29,8 +29,8 @@ private static TemporaryDirectory MakeTemporaryDirectory()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the port is not specified.
-        /// In this case, the Registry proxy should not be created.
+        /// Verify that the registry proxy correctly handles the case where the port is not specified.
+        /// In this case, the registry proxy should not be created.
         /// </summary>
         [Fact]
         public void TestRegistryProxyNoPort()
@@ -51,8 +51,8 @@ public void TestRegistryProxyNoPort()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the host is not specified.
-        /// In this case, the Registry proxy should not be created.
+        /// Verify that the registry proxy correctly handles the case where the host is not specified.
+        /// In this case, the registry proxy should not be created.
         /// </summary>
         [Fact]
         public void TestRegistryProxyNoHost()
@@ -105,7 +105,7 @@ public void TestRegistryProxyNoHost()
         """;
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case
+        /// Verify that the registry proxy correctly handles the case
         /// where the port, host, and certificate are specified.
         /// </summary>
         [Fact]
@@ -131,9 +131,9 @@ public void TestRegistryProxyCertificate()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the RegistryURLs environment variable
+        /// Verify that the registry proxy correctly handles the case where the RegistryURLs environment variable
         /// is not a valid JSON list.
-        /// In this case, the Registry proxy should be created, but the list of private registries should be empty.
+        /// In this case, the registry proxy should be created, but the list of private registries should be empty.
         /// </summary>
         [Fact]
         public void TestRegistryProxyUrlsParseError()
@@ -157,9 +157,9 @@ public void TestRegistryProxyUrlsParseError()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the RegistryURLs environment variable
+        /// Verify that the registry proxy correctly handles the case where the RegistryURLs environment variable
         /// is a valid JSON list with a single entry.
-        /// In this case, the Registry proxy should be created, and the list of private registries should contain the single entry.
+        /// In this case, the registry proxy should be created, and the list of private registries should contain the single entry.
         /// </summary>
         [Fact]
         public void TestRegistryProxyUrlsSingle()
@@ -185,10 +185,10 @@ public void TestRegistryProxyUrlsSingle()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the RegistryURLs environment variable
+        /// Verify that the registry proxy correctly handles the case where the RegistryURLs environment variable
         /// is a valid JSON list with multiple entries, but only one of them is of type "nuget_feed", which is
         /// relevant for C#.
-        /// In this case, the Registry proxy should be created, and the list of private registries should
+        /// In this case, the registry proxy should be created, and the list of private registries should
         /// contain only the entry of type "nuget_feed".
         /// </summary>
         [Fact]
@@ -215,9 +215,9 @@ public void TestRegistryProxyUrls3()
         }
 
         /// <summary>
-        /// Verify that the Registry proxy correctly handles the case where the RegistryURLs environment variable
+        /// Verify that the registry proxy correctly handles the case where the RegistryURLs environment variable
         /// is a valid JSON list with multiple entries and one of them is configured to replace the base feeds.
-        /// In this case, the Registry proxy should be created, and the list of private registries should contain all
+        /// In this case, the registry proxy should be created, and the list of private registries should contain all
         /// entries, while the list of base registries should contain only the entry that replaces the base feeds.
         /// </summary>
         [Fact]