No need for mapping in Ownable.sol?

[Nikhil22]

I am wondering why you are storing owner in a mapping. Since you set the current owner value to false when there is a transfer of ownership, why not just have a single address public owner?

[Ryanmtate]

Hey @Nikhil22

Thanks for the question.

The single mapping allows for only one owner; which in the future may be preferable, allowing for a second layer of key management (e.g. Shamir secret + central signer).

However, the mapping(address => bool) owners; allows for multiple owners simultaneously. This is used by the GitToken webhook signer and also allows for organization admins to have ownership control.

[Ryanmtate]

I am considering using a separate modifier for the webhook signer. something like:

address signer;

modifier isSigner() {
  require(msg.sender == signer);
  _;
}

Would this be preferable in your opinion @Nikhil22 ?

[Nikhil22]

Using a separate modifier for the signer is more clear, I'm for it.