From cefd1d2762ce3afc5834d01bb57a9351615cdb65 Mon Sep 17 00:00:00 2001
From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com>
Date: Mon, 24 Aug 2026 05:24:00 +0000
Subject: [PATCH] fix(OSQUERY-003): RegistryType::add() throws
 std::runtime_error instead of returning Status::failure()

---
 osquery/registry/registry_interface.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/osquery/registry/registry_interface.h b/osquery/registry/registry_interface.h
index 7553cd3be6f..bab2fa34b1b 100644
--- a/osquery/registry/registry_interface.h
+++ b/osquery/registry/registry_interface.h
@@ -266,8 +266,8 @@ class RegistryType : public RegistryInterface {
              const PluginRef& plugin_item,
              bool internal = false) override {
     if (nullptr == std::dynamic_pointer_cast<PluginType>(plugin_item)) {
-      throw std::runtime_error("Cannot add foreign plugin type: " +
-                               plugin_name);
+      return Status::failure("Cannot add foreign plugin type: " +
+                             plugin_name);
     }
     return addPlugin(plugin_name, plugin_item, internal);
   }
@@ -349,3 +349,4 @@ class AutoRegisterInterface {
 
 void registryAndPluginInit();
 } // namespace osquery
+