From 14a30d5167153d576d8bd113350de6f2eca06fe5 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 24 Aug 2026 05:03:35 +0000 Subject: [PATCH] fix(OFJAVA-018): 2 review findings in CacheServiceAbs.java --- .../java/cx/flamingo/analysis/cache/CacheServiceAbs.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/backend/src/main/java/cx/flamingo/analysis/cache/CacheServiceAbs.java b/backend/src/main/java/cx/flamingo/analysis/cache/CacheServiceAbs.java index 6682343..5e5243c 100644 --- a/backend/src/main/java/cx/flamingo/analysis/cache/CacheServiceAbs.java +++ b/backend/src/main/java/cx/flamingo/analysis/cache/CacheServiceAbs.java @@ -71,7 +71,7 @@ protected boolean isCacheEntryStale(String cachePath, String key, Long refreshIn } return isStale; } catch (Throwable e) { - log.error("Error checking cache entry age: {}", e.getMessage()); + log.error("Error checking cache entry age", e); return true; // Consider it stale if we can't check } } @@ -161,7 +161,7 @@ protected Optional doHttpCall(Supplier supplier, String cachePath, Str put(cachePath, cacheKey, response); return Optional.of(response); } catch (Exception e) { - log.error("Error fetching data: {}", e.getMessage()); + log.error("Error fetching data", e); return Optional.empty(); } } @@ -247,3 +247,4 @@ public void setCacheMode(CacheMode cacheMode) { this.cacheMode = cacheMode; } } +