From b938f56819e84b7d81fc094599a311e8e9b5ead4 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 24 Aug 2026 06:43:27 +0000 Subject: [PATCH 1/3] fix(FLEETMDM-003): 6 review findings across 3 files --- orbit/pkg/go-paniclog/paniclog_unix.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/orbit/pkg/go-paniclog/paniclog_unix.go b/orbit/pkg/go-paniclog/paniclog_unix.go index 08bf190b0e7..bac84ed773f 100644 --- a/orbit/pkg/go-paniclog/paniclog_unix.go +++ b/orbit/pkg/go-paniclog/paniclog_unix.go @@ -6,7 +6,7 @@ package paniclog import ( - "errors" + "fmt" "os" "golang.org/x/sys/unix" @@ -16,12 +16,12 @@ func redirectStderr(f *os.File) (UndoFunction, error) { stderrFd := int(os.Stderr.Fd()) oldfd, err := unix.Dup(stderrFd) if err != nil { - return nil, errors.New("Failed to redirect stderr to file: " + err.Error()) + return nil, fmt.Errorf("redirect stderr to file: %w", err) } err = unix.Dup2(int(f.Fd()), stderrFd) if err != nil { - return nil, errors.New("Failed to redirect stderr to file: " + err.Error()) + return nil, fmt.Errorf("redirect stderr to file: %w", err) } undo := func() error { @@ -29,7 +29,7 @@ func redirectStderr(f *os.File) (UndoFunction, error) { unix.Close(oldfd) if undoErr != nil { - return errors.New("Failed to reverse stderr redirection: " + err.Error()) + return fmt.Errorf("reverse stderr redirection: %w", undoErr) } return nil From cdd4d0dfd3ac54343ba5d5c9a56ee18973af6c34 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 24 Aug 2026 06:43:28 +0000 Subject: [PATCH 2/3] fix(FLEETMDM-003): 6 review findings across 3 files --- orbit/pkg/table/app_sso_platform/app_sso_platform_darwin.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/orbit/pkg/table/app_sso_platform/app_sso_platform_darwin.go b/orbit/pkg/table/app_sso_platform/app_sso_platform_darwin.go index ad079368287..5660a4c9992 100644 --- a/orbit/pkg/table/app_sso_platform/app_sso_platform_darwin.go +++ b/orbit/pkg/table/app_sso_platform/app_sso_platform_darwin.go @@ -232,7 +232,7 @@ func parseAppSSOPlatformCommandOutput(output []byte, expectedExtensionIdentifier } realm, ok := realm_.(string) if !ok { - return nil, fmt.Errorf("unexpected type for \"realm\" key in \"kerberosStatus\": %T", err) + return nil, fmt.Errorf("unexpected type for \"realm\" key in \"kerberosStatus\": %T", realm_) } upn_, ok := userConfig.KerberosStatus[0]["upn"] if !ok { @@ -240,7 +240,7 @@ func parseAppSSOPlatformCommandOutput(output []byte, expectedExtensionIdentifier } upn, ok := upn_.(string) if !ok { - return nil, fmt.Errorf("unexpected type for \"upn\" key in \"kerberosStatus\": %T", err) + return nil, fmt.Errorf("unexpected type for \"upn\" key in \"kerberosStatus\": %T", upn_) } if upn == "" { return nil, errors.New("empty \"upn\" key in \"kerberosStatus\"") From b60e5db0752959eef87cbf6d8158aef7f8e9621b Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 24 Aug 2026 06:43:29 +0000 Subject: [PATCH 3/3] fix(FLEETMDM-003): 6 review findings across 3 files --- orbit/pkg/table/cis_audit/cis_audit_windows.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/orbit/pkg/table/cis_audit/cis_audit_windows.go b/orbit/pkg/table/cis_audit/cis_audit_windows.go index 17a86f61ede..20da02897c2 100644 --- a/orbit/pkg/table/cis_audit/cis_audit_windows.go +++ b/orbit/pkg/table/cis_audit/cis_audit_windows.go @@ -250,8 +250,7 @@ func getSeceditData() (SeceditData, error) { // Load the .inf file content cfg, err := ini.Load(fileContent) if err != nil { - fmt.Printf("Error: %v\n", err) - return data, err + return data, fmt.Errorf("failed to load secedit inf file: %w", err) } // Parse System Access section