From 3141fadd5815155ec2a861978b6a1cdef662e003 Mon Sep 17 00:00:00 2001
From: "Anthony Fu (via agent)" <reg-github-bot@antfu.me>
Date: Fri, 14 Aug 2026 05:20:58 +0000
Subject: [PATCH] feat(hub,hub-ui): color a dock-bar entry's badge via
 badgeVariant
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Port of vitejs/devtools#528 by @dvcolomban, adapted for this repo's own
split into `@devframes/hub` (types) and `@devframes/hub-ui` (dock
components) — the field lands directly on `DevframeDockEntryBase`
rather than via a cross-package `declare module` augmentation, since
the augmenting and augmented packages both live here now.

`badgeVariant?: 'default' | 'info' | 'success' | 'warning' | 'danger'`
mirrors json-render's `TabDescriptor.badgeVariant` / `Badge.ts` variant
naming. `DockEntry.vue` applies it as an inline fill, falling back to
the existing neutral classes at `'default'`/unset so every current
badge consumer keeps its look. Threaded through `DockEntries.vue` and
`DockGroupButton.vue`, with new stories in `DockEntry.stories.ts`.

Closes #214.

Co-authored-by: Dinh-Van Colomban <dinh-van.colomban@contentsquare.com>
---
 .../client/components/dock/DockEntries.vue    |  1 +
 .../components/dock/DockEntry.stories.ts      |  7 +++++
 .../src/client/components/dock/DockEntry.vue  | 31 +++++++++++++++++--
 .../components/dock/DockGroupButton.vue       |  1 +
 packages/hub/src/types/docks.ts               |  8 +++++
 .../tsnapi/@devframes/hub/index.snapshot.d.ts |  2 ++
 .../tsnapi/@devframes/hub/types.snapshot.d.ts |  1 +
 7 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/packages/hub-ui/src/client/components/dock/DockEntries.vue b/packages/hub-ui/src/client/components/dock/DockEntries.vue
index db5661c2..8c5a0045 100644
--- a/packages/hub-ui/src/client/components/dock/DockEntries.vue
+++ b/packages/hub-ui/src/client/components/dock/DockEntries.vue
@@ -77,6 +77,7 @@ function toggleDockEntry(dock: DevframeDockEntry) {
         :is-dimmed="dimInactive && selected ? (selected.id !== dock.id) : false"
         :is-vertical="isVertical"
         :badge="dock.badge"
+        :badge-variant="dock.badgeVariant"
         @click="toggleDockEntry(dock)"
       />
     </template>
diff --git a/packages/hub-ui/src/client/components/dock/DockEntry.stories.ts b/packages/hub-ui/src/client/components/dock/DockEntry.stories.ts
index 5eca6025..0bfc60ac 100644
--- a/packages/hub-ui/src/client/components/dock/DockEntry.stories.ts
+++ b/packages/hub-ui/src/client/components/dock/DockEntry.stories.ts
@@ -12,6 +12,7 @@ interface EntryArgs {
   isVertical?: boolean
   isAction?: boolean
   badge?: string
+  badgeVariant?: 'default' | 'info' | 'success' | 'warning' | 'danger'
   tooltip?: boolean
 }
 
@@ -43,6 +44,7 @@ const meta = {
         isVertical: args.isVertical,
         isAction: args.isAction,
         badge: args.badge || undefined,
+        badgeVariant: args.badgeVariant,
         tooltip: args.tooltip,
       }))),
     ),
@@ -67,6 +69,9 @@ export const Action: Story = { args: { isAction: true } }
 /** A count badge in the corner (e.g. pending items). */
 export const WithBadge: Story = { args: { badge: '3' } }
 
+/** A colored badge, e.g. flagging a state that needs attention. */
+export const WithBadgeVariant: Story = { args: { badge: '3', badgeVariant: 'warning' } }
+
 /** Rotated for a left/right edge dock. */
 export const Vertical: Story = { args: { isVertical: true } }
 
@@ -81,6 +86,8 @@ export const States: Story = {
         h(DockEntry, { context: ctx, dock: sample, isDimmed: true }),
         h(DockEntry, { context: ctx, dock: sample, isAction: true }),
         h(DockEntry, { context: ctx, dock: sample, badge: '9+' }),
+        h(DockEntry, { context: ctx, dock: sample, badge: '2', badgeVariant: 'warning' }),
+        h(DockEntry, { context: ctx, dock: sample, badge: '5', badgeVariant: 'success' }),
       ])),
     ),
   }),
diff --git a/packages/hub-ui/src/client/components/dock/DockEntry.vue b/packages/hub-ui/src/client/components/dock/DockEntry.vue
index 8e76f0a9..c6c609e7 100644
--- a/packages/hub-ui/src/client/components/dock/DockEntry.vue
+++ b/packages/hub-ui/src/client/components/dock/DockEntry.vue
@@ -1,8 +1,8 @@
 <script setup lang="ts">
-import type { DevframeDockEntryBase } from '@devframes/hub'
+import type { DevframeDockBadgeVariant, DevframeDockEntryBase } from '@devframes/hub'
 import type { DocksContext } from '@devframes/hub/client'
 import { useEventListener } from '@vueuse/core'
-import { useTemplateRef } from 'vue'
+import { computed, useTemplateRef } from 'vue'
 import { setFloatingTooltip } from '../../state/floating-tooltip'
 import { openDockContextMenu } from './DockContextMenu'
 import DockIcon from './DockIcon.vue'
@@ -16,6 +16,7 @@ const props = withDefaults(
     isDimmed?: boolean
     isVertical?: boolean
     badge?: string
+    badgeVariant?: DevframeDockBadgeVariant
     tooltip?: boolean
   }>(),
   {
@@ -23,6 +24,25 @@ const props = withDefaults(
   },
 )
 
+// Mirrors json-render's `Badge` variant→color-name map (see
+// `@devframes/json-render-ui`'s `Badge.ts`), applied as an inline fill since
+// the dock bar doesn't pull in json-render-ui's `DisplayBadge` component.
+// `undefined` at `'default'`/unset keeps the existing `bg-primary text-white`
+// classes below — every existing badge consumer keeps its current look.
+const badgeColors: Record<Exclude<DevframeDockBadgeVariant, 'default'>, { bg: string, fg: string }> = {
+  info: { bg: '#3b82f6', fg: '#eff6ff' },
+  success: { bg: '#22c55e', fg: '#f0fdf4' },
+  warning: { bg: '#f59e0b', fg: '#fffbeb' },
+  danger: { bg: '#ef4444', fg: '#fef2f2' },
+}
+
+const badgeStyle = computed(() => {
+  if (!props.badgeVariant || props.badgeVariant === 'default')
+    return undefined
+  const { bg, fg } = badgeColors[props.badgeVariant]
+  return { backgroundColor: bg, color: fg }
+})
+
 const button = useTemplateRef<HTMLButtonElement>('button')
 
 function updateTooltip() {
@@ -87,7 +107,12 @@ useEventListener('pointerdown', () => {
       class="flex items-center justify-center p1.5 hover:bg-[#8881] hover:scale-110 transition-all duration-300 relative outline-none"
     >
       <DockIcon :icon="dock.icon" class="w-5 h-5 select-none" />
-      <div v-if="badge" class="absolute top-0.5 right-0 bg-primary text-white text-0.6em px-1 rounded-full shadow">
+      <div
+        v-if="badge"
+        class="absolute top-0.5 right-0 text-0.6em px-1 rounded-full shadow"
+        :class="badgeStyle ? '' : 'bg-primary text-white'"
+        :style="badgeStyle"
+      >
         {{ badge }}
       </div>
     </button>
diff --git a/packages/hub-ui/src/client/components/dock/DockGroupButton.vue b/packages/hub-ui/src/client/components/dock/DockGroupButton.vue
index 394d7cbc..4c576e66 100644
--- a/packages/hub-ui/src/client/components/dock/DockGroupButton.vue
+++ b/packages/hub-ui/src/client/components/dock/DockGroupButton.vue
@@ -128,6 +128,7 @@ function onClick() {
       :is-selected="isActive || isPanelVisible"
       :is-dimmed="dimInactive && selected ? !isActive : false"
       :badge="group.badge"
+      :badge-variant="group.badgeVariant"
       @click="onClick"
     />
   </div>
diff --git a/packages/hub/src/types/docks.ts b/packages/hub/src/types/docks.ts
index 7551ae43..65d4568f 100644
--- a/packages/hub/src/types/docks.ts
+++ b/packages/hub/src/types/docks.ts
@@ -69,6 +69,9 @@ export type DevframeDockEntryCategory
 
 export type DevframeDockEntryIcon = string | { light: string, dark: string }
 
+/** Color for a dock-bar entry's {@link DevframeDockEntryBase.badge} — mirrors json-render's `TabDescriptor.badgeVariant`. */
+export type DevframeDockBadgeVariant = 'default' | 'info' | 'success' | 'warning' | 'danger'
+
 export interface DevframeDockEntryBase {
   id: string
   title: string
@@ -133,6 +136,11 @@ export interface DevframeDockEntryBase {
    * Badge text to display on the dock icon (e.g., unread count)
    */
   badge?: string
+  /**
+   * Colors {@link badge}. Omitted (or `'default'`) keeps the existing neutral
+   * fill, so every pre-existing badge consumer keeps its current look.
+   */
+  badgeVariant?: DevframeDockBadgeVariant
   /**
    * Id of the group this entry belongs to. When set, hosts collapse this entry
    * under the matching group's button instead of showing it directly on the
diff --git a/tests/__snapshots__/tsnapi/@devframes/hub/index.snapshot.d.ts b/tests/__snapshots__/tsnapi/@devframes/hub/index.snapshot.d.ts
index 20672820..4ba6edb5 100644
--- a/tests/__snapshots__/tsnapi/@devframes/hub/index.snapshot.d.ts
+++ b/tests/__snapshots__/tsnapi/@devframes/hub/index.snapshot.d.ts
@@ -90,6 +90,7 @@ export interface DevframeDockEntryBase {
   when?: string;
   visibility?: string;
   badge?: string;
+  badgeVariant?: DevframeDockBadgeVariant;
   groupId?: string;
 }
 export interface DevframeDockEntryRegistry {
@@ -339,6 +340,7 @@ export interface RemoteDockOptions {
 
 // #region Types
 export type DevframeCommandEntry = DevframeServerCommandEntry | DevframeClientCommand;
+export type DevframeDockBadgeVariant = 'default' | 'info' | 'success' | 'warning' | 'danger';
 export type DevframeDockEntriesGrouped = [category: string, entries: DevframeDockEntry[]][];
 export type DevframeDockEntry = DevframeDockUserEntry;
 export type DevframeDockEntryCategory = 'framework' | 'app' | 'ui' | 'data' | 'web' | 'performance' | 'advanced' | 'docs' | 'default' | '~builtin' | (string & {});
diff --git a/tests/__snapshots__/tsnapi/@devframes/hub/types.snapshot.d.ts b/tests/__snapshots__/tsnapi/@devframes/hub/types.snapshot.d.ts
index fae942b8..40f0ac3c 100644
--- a/tests/__snapshots__/tsnapi/@devframes/hub/types.snapshot.d.ts
+++ b/tests/__snapshots__/tsnapi/@devframes/hub/types.snapshot.d.ts
@@ -23,6 +23,7 @@ export { DevframeDiagnosticsDefinition }
 export { DevframeDiagnosticsHost }
 export { DevframeDiagnosticsLogger }
 export { DevframeDockActivation }
+export { DevframeDockBadgeVariant }
 export { DevframeDockEntriesGrouped }
 export { DevframeDockEntry }
 export { DevframeDockEntryBase }