v4 : Do not require guzzle anymore ?

[yched]

What problem does your feature request address?

Since v4 allows using a custom HttpClientFactory that is not Guzzle, and simply uses Guzzle as a default,
it would be nice to not force a hard-dependency on "guzzlehttp/guzzle": ">=7" in its composer.json "require" section.
If I'm using a non-Guzzle HttpClientFactory, then I don't need/want Guzzle in my vendor folder ;-)

Maybe it should just list "guzzlehttp/guzzle" in the "suggest" section ?

Describe the desired solution

No response

Alternatives considered

No response

Additional context

No response

[ychedemois]

https://packagist.org/packages/php-http/discovery should allow automatic discovery of a PSR18 HTTP client available,
and also of a Request factory, thus removing the need for providing client-specific implementations of HttpClientFactory::createRequest()

[cb-alish]

Hi @ychedemois, sorry this was missed. We’ll look into it. If adding this turns out to be a non-breaking change, we’ll definitely include it.

[ychedemois]

Hi @cb-alish no problem ;-)
I myself only recently bumped into php-http/discovery,
and I suspect it might greatly simplify the code around the generic PSR18 support that was added in v4

[cb-alish]

Hi @yched, Sorry for the delayed response.

We’ve added support for injecting PSR HTTP primitive interfaces directly during HTTP client injection in this PR: #127. I’d really appreciate it if you could take a look and share your feedback.

Regarding removing Guzzle from require:

We’d very much like to, and it’s fully planned. However, doing so in the current major version would be a semver-breaking change. At the moment, users who rely on the default setup (without injecting a client) receive Guzzle transitively through us. Removing it without a major version bump could silently break applications during upgrade, which we want to avoid.

Thanks again for your time and review!

[ychedemois]

The PR is awesome, thanks @cb-alish !

Regarding the guzzle requirement : yeah, I tried to think of a way as well, but removing it does seem like a BC break requiring a major version 🤷‍♂️