Skip to content

Community Feedback Requested: Should we have named clients default to the default client if no default is registered? #4

Description

@binn

When using DI, if IVRChatClientFactory.CreateClient() is called, and no default IVRChat was registered, then it will return the first available named client.

This may lead to unexpected behavior or bugs when consuming the library (and unaware of what the actual problem is), but also may make life easier when clients are left unregistered.

I wanted to obtain community feedback before implementing a complete change.

The implementation of this behavior is located here and here

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or requesthelp wantedExtra attention is neededquestionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions