Skip to content

hacker-news.py isn't work correctly #2

Description

@m15kh

hi
your code of hacker-news.py doesn't work correctly and you should edit like this

import requests
import re
from bs4 import BeautifulSoup

url = 'https://news.ycombinator.com/news'
articles = []
r = requests.get(url)
content = BeautifulSoup(r.text, 'html.parser')

for item in content.find_all('tr', class_='athing'):
    item_a = item.find('span', class_='titleline')  #EDIT
    item_link = item_a.find('a')['href'] if item_a else None #EDIT
    item_text = item_a.get_text(strip=True) if item_a else None
    next_row = item.find_next_sibling('tr')
    item_score = next_row.find('span', class_='score')
    item_score = item_score.get_text(strip=True) if item_score else '0 points'
    item_comments = next_row.find('a', text=re.compile('\d+( |\s)comment(s?)'))
    item_comments = item_comments.get_text(strip=True).replace('\xa0', ' ') if item_comments else '0 comments'

    articles.append({
        'link': item_link,
        'title': item_text,
        'score': item_score,
        'comments': item_comments
    })

for article in articles:
    print(article)
    print('-' * 50)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions