From 7e1a251782fb724b8a51a25e88bce1dc590920bc Mon Sep 17 00:00:00 2001
From: ff225 <frafranco16@gmail.com>
Date: Mon, 13 Jul 2026 16:34:53 +0200
Subject: [PATCH] fix(communication): remove unfinished get_synthetic_latency
 placeholder

get_synthetic_latency() always returned 1 and was only ever multiplied
into get_avg_speed's latency term, making it a no-op. Drop it instead
of finishing the implementation since no intended semantics were
documented anywhere.

Closes #50
---
 src/server/communication/message_data.py    | 12 ++----------
 src/server/communication/request_handler.py |  2 --
 tests/unit/test_message_data.py             | 17 +++++++++++++++++
 3 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/src/server/communication/message_data.py b/src/server/communication/message_data.py
index bbe3e1b..595a730 100644
--- a/src/server/communication/message_data.py
+++ b/src/server/communication/message_data.py
@@ -17,7 +17,6 @@ class MessageData:
     received_timestamp = None
     avg_speed = None
     latency = None
-    synthetic_latency = None
     payload_size = None
     offloading_layer_index = None
     layer_output = None
@@ -59,16 +58,9 @@ def get_bytes_size(payload) -> int:
         return len(payload)
 
     @staticmethod
-    def get_synthetic_latency() -> float:
-        return 1
-
-    @staticmethod
-    def get_avg_speed(
-        payload_size: float, latency: float, synthetic_latency: float
-    ) -> float:
-        message_latency = latency * synthetic_latency
+    def get_avg_speed(payload_size: float, latency: float) -> float:
         try:
-            avg_speed = payload_size / message_latency
+            avg_speed = payload_size / latency
         except ZeroDivisionError:
             avg_speed = 0
         return avg_speed
diff --git a/src/server/communication/request_handler.py b/src/server/communication/request_handler.py
index 21a4008..cd98154 100644
--- a/src/server/communication/request_handler.py
+++ b/src/server/communication/request_handler.py
@@ -856,14 +856,12 @@ def _extend_message_data(
         # update stats info
         message_data.received_timestamp = received_timestamp
         message_data.payload_size = MessageData.get_bytes_size(payload)
-        message_data.synthetic_latency = MessageData.get_synthetic_latency()
         message_data.latency = MessageData.get_latency(
             message_data.timestamp, message_data.received_timestamp
         )
         message_data.avg_speed = MessageData.get_avg_speed(
             message_data.payload_size,
             message_data.latency,
-            message_data.synthetic_latency,
         )
         # update offloading info
         (
diff --git a/tests/unit/test_message_data.py b/tests/unit/test_message_data.py
index 1a0789d..197ce6c 100644
--- a/tests/unit/test_message_data.py
+++ b/tests/unit/test_message_data.py
@@ -14,3 +14,20 @@ def test_get_latency_annotation_matches_return_type():
     annotations = get_type_hints(MessageData.get_latency)
 
     assert annotations["return"] is float
+
+
+def test_get_synthetic_latency_placeholder_removed():
+    assert not hasattr(MessageData, "get_synthetic_latency")
+    assert not hasattr(MessageData, "synthetic_latency")
+
+
+def test_get_avg_speed_computes_payload_over_latency():
+    avg_speed = MessageData.get_avg_speed(payload_size=100.0, latency=2.0)
+
+    assert avg_speed == 50.0
+
+
+def test_get_avg_speed_returns_zero_on_zero_latency():
+    avg_speed = MessageData.get_avg_speed(payload_size=100.0, latency=0.0)
+
+    assert avg_speed == 0