test: tests for KnowledgeGraph::onSidebarBeforeOutput() and ensureKnowledgeGraphOptionsPageExists()

[gesinn-it-gea]

Goal

Two hook-adjacent methods with no test coverage.

Test scenarios

onSidebarBeforeOutput() (includes/KnowledgeGraph.php:195-206)

• $wgKnowledgeGraphShowSidebarLink is false/empty → early return, $sidebar remains unchanged.
• $wgKnowledgeGraphShowSidebarLink is true → $sidebar['TOOLBOX'][] receives an entry with the correct text (from wfMessage('knowledgegraph-knowledgegraphdesigner-label')) and href (URL of the KnowledgeGraphDesigner special page).

ensureKnowledgeGraphOptionsPageExists() (includes/KnowledgeGraph.php:148-181, private, currently only reachable indirectly via onBeforePageDisplay())

• The page MediaWiki:KnowledgeGraphOptions already exists → no write happens (saveRevision is not called).
• The page is missing → it is created from data/KnowledgeGraphOptions.js (content model CONTENT_MODEL_JAVASCRIPT, author is the MediaWiki default system user).
• The template file is missing (file_exists() returns false) → the method aborts without error (only a debug log).

Mocking pattern

Integration test (MediaWikiIntegrationTestCase) recommended, since real page creation (WikiPage::newPageUpdater) is involved. ensureKnowledgeGraphOptionsPageExists() is private — test it via the public onBeforePageDisplay() hook, or via reflection (ReflectionMethod::setAccessible).

Part of the "raise PHP coverage to ~70%" effort.

[gesinn-it-gea]

Resolved by commits 84e04cc, 04c302e, and 0d91dde:

• 04c302e adds KnowledgeGraphOnSidebarBeforeOutputTest and KnowledgeGraphEnsureKnowledgeGraphOptionsPageExistsTest, covering exactly the scenarios described above (sidebar flag off/empty/unset, TOOLBOX entry text/href on enable, page creation from data/KnowledgeGraphOptions.js vs. existing-page-left-untouched), exercising the private ensureKnowledgeGraphOptionsPageExists() via the public onBeforePageDisplay() hook as suggested.
• Writing the onSidebarBeforeOutput() test uncovered a real bug: SpecialPage::getTitleFor('KnowledgeGraphDesigner') fataled with "Did not find alias for special page" because SpecialPageAliases was never registered in extension.json. Fixed in 84e04cc.
• 0d91dde documents both in the changelog.

The missing-template-file branch (file_exists() === false) is intentionally left uncovered with a documented rationale (would require deleting the shipped template file, affecting concurrent test runs).

Verified just now: full PHPUnit suite passes (120 tests, 198 assertions, 0 failures).