test: tests for smaller helper methods in KnowledgeGraph (applyDefaultParams, parseParameters, makeRelationKey, resetSeenRelations)

[gesinn-it-gea]

Goal

Several pure helper methods without MediaWiki context dependencies are untested or only indirectly covered via SpecialKnowledgeGraphDesignerTest.php. Low test effort, good coverage payoff per line of test code.

Test scenarios

applyDefaultParams() (includes/KnowledgeGraph.php:498-540)

• Type bool/boolean: a valid value is converted to bool correctly; an invalid value falls back to the default (also interpreted via filter_var).
• Type array: a comma-separated string is split correctly and empty entries are removed.
• Type number: valid/invalid float value.
• Type int/integer: valid/invalid integer value.
• Unknown type (default branch): value is passed through unchanged.
• Missing key in $params → default value is used.

parseParameters() (includes/KnowledgeGraph.php:548-565)

• A known parameter (key=value) is extracted into $options, including normalization of spaces to hyphens in the key.
• An unknown parameter or a value without = remains in the returned list ($ret).

makeRelationKey() (includes/KnowledgeGraph.php:813-817)

• makeRelationKey('A', 'B', 'prop') and makeRelationKey('B', 'A', 'prop') produce the same key (reflection needed, since it's private).

resetSeenRelations() (includes/KnowledgeGraph.php:819-821)

• Resets self::$relationsSeen to [] (reflection-based assertion before/after the call).

Mocking pattern

No mocks needed — plain PHPUnit\Framework\TestCase tests. Use reflection for private/static properties, analogous to tests/phpunit/Unit/KnowledgeGraphSetSemanticDataFromApiTest.php.

Part of the "raise PHP coverage to ~70%" effort.

[gesinn-it-gea]

Resolved by 7391615 (test(includes): add coverage for KnowledgeGraph helper methods).

KnowledgeGraphApplyDefaultParamsTest, KnowledgeGraphParseParametersTest, KnowledgeGraphMakeRelationKeyTest, KnowledgeGraphResetSeenRelationsTest cover all scenarios listed above:

• applyDefaultParams(): bool/boolean valid + invalid-falls-back-to-default, array comma-split with empty-entry removal, number/int valid conversion, unknown type pass-through, missing key → default (with and without type coercion)
• parseParameters(): known key extraction incl. space-to-hyphen normalization, unknown key / no-= value retained in $ret, mixed list split correctly
• makeRelationKey(): order-independence between A/B via reflection, exact key format
• resetSeenRelations(): resets self::$relationsSeen to [] via reflection

Also documents a likely bug (not fixed here, out of scope for a test-only issue): in applyDefaultParams(), an invalid number/int value is meant to fall back to the configured default (as bool/boolean does), but filter_var(..., FILTER_NULL_ON_FAILURE) followed by settype(null, 'float'|'integer') silently produces 0.0/0 instead, ignoring the default. Worth a follow-up issue if that behavior should actually respect the default.

Verified locally: filtered run → 18 tests, 23 assertions, all passing.