Skip to content

2d and 3d implementation differences #43

Description

@ivanstepanovftw

While comparing line-by-line 2d and 3d implementation, I noticed that 2d have mask, while 3d implementation have mask_in.
Here is the line-by-line comparison:

# 2d
raw_out = super(PartialConv2d, self).forward(torch.mul(input, mask) if mask_in is not None else input)
# 3d
raw_out = super(PartialConv3d, self).forward(torch.mul(input, mask_in) if mask_in is not None else input)

Is there a bug? Which one is correct?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions