From c0e2d976cd7ed5cc64246ff52616d1d498ead294 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lorenz=20K=C3=A4stle?= Date: Tue, 15 Sep 2026 10:28:53 +0200 Subject: [PATCH] Remove/change misleading parameter help --- cmd/cpu.go | 4 ++-- cmd/datastore.go | 4 ++-- cmd/hba.go | 6 +++--- cmd/memory.go | 4 ++-- cmd/nic.go | 6 +++--- cmd/temperature.go | 4 ++-- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/cmd/cpu.go b/cmd/cpu.go index 5b317f3..c3ab588 100644 --- a/cmd/cpu.go +++ b/cmd/cpu.go @@ -24,8 +24,8 @@ var cpuCmd = &cobra.Command{ func init() { rootCmd.AddCommand(cpuCmd) - cpuCmd.Flags().StringVarP(&cpuWarning, "warning", "w", "80", "Warning threshold in percent") - cpuCmd.Flags().StringVarP(&cpuCritical, "critical", "c", "90", "Critical threshold in percent") + cpuCmd.Flags().StringVarP(&cpuWarning, "warning", "w", "80", "Warning threshold range in percent") + cpuCmd.Flags().StringVarP(&cpuCritical, "critical", "c", "90", "Critical threshold range in percent") } // Query for CPU usage of the given machine, exit with UNKNOWN on query errors. diff --git a/cmd/datastore.go b/cmd/datastore.go index 30e34c8..25f9161 100644 --- a/cmd/datastore.go +++ b/cmd/datastore.go @@ -34,8 +34,8 @@ var datastoreCmd = &cobra.Command{ func init() { rootCmd.AddCommand(datastoreCmd) - datastoreCmd.Flags().StringVarP(&datastoreWarning, "warning", "w", "80", "Warning threshold in percent") - datastoreCmd.Flags().StringVarP(&datastoreCritical, "critical", "c", "90", "Critical threshold in percent") + datastoreCmd.Flags().StringVarP(&datastoreWarning, "warning", "w", "80", "Warning threshold range in percent") + datastoreCmd.Flags().StringVarP(&datastoreCritical, "critical", "c", "90", "Critical threshold range in percent") datastoreCmd.Flags().StringVarP(&datastore, "datastore", "", "", "Name of the datastore to check") } diff --git a/cmd/hba.go b/cmd/hba.go index 20c3c78..afb7962 100644 --- a/cmd/hba.go +++ b/cmd/hba.go @@ -16,7 +16,7 @@ var hbaCritThreshold *check.Threshold var hbaCmd = &cobra.Command{ Use: "hba", - Short: "Checks attached HBAs. Uses negative thresholds as parameters, e.g. 10:", + Short: "Checks attached HBAs. Uses threshold ranges as parameters, e.g. 10:", Run: func(_ *cobra.Command, _ []string) { queryHba() }, @@ -25,8 +25,8 @@ var hbaCmd = &cobra.Command{ func init() { rootCmd.AddCommand(hbaCmd) - hbaCmd.Flags().StringVarP(&hbaWarning, "warning", "w", "2:", "Warning threshold (\"less than X available\")") - hbaCmd.Flags().StringVarP(&hbaCritical, "critical", "c", "1:", "Critical threshold (\"less than X available\")") + hbaCmd.Flags().StringVarP(&hbaWarning, "warning", "w", "2:", "Warning threshold range") + hbaCmd.Flags().StringVarP(&hbaCritical, "critical", "c", "1:", "Critical threshold range") } func queryHba() { diff --git a/cmd/memory.go b/cmd/memory.go index a7d8307..c2b102c 100644 --- a/cmd/memory.go +++ b/cmd/memory.go @@ -25,8 +25,8 @@ var memoryCmd = &cobra.Command{ func init() { rootCmd.AddCommand(memoryCmd) - memoryCmd.Flags().StringVarP(&memoryWarning, "warning", "w", "80", "Warning threshold in percent") - memoryCmd.Flags().StringVarP(&memoryCritical, "critical", "c", "90", "Critical threshold in percent") + memoryCmd.Flags().StringVarP(&memoryWarning, "warning", "w", "80", "Warning threshold range in percent") + memoryCmd.Flags().StringVarP(&memoryCritical, "critical", "c", "90", "Critical threshold range in percent") } // Query for memory usage of the given machine, exit with UNKNOWN on query errors. diff --git a/cmd/nic.go b/cmd/nic.go index 82d2408..f70be8c 100644 --- a/cmd/nic.go +++ b/cmd/nic.go @@ -16,7 +16,7 @@ var nicCritThreshold *check.Threshold var nicCmd = &cobra.Command{ Use: "nic", - Short: "Checks the number of attached NICs. Uses negative thresholds as parameters, e.g. 10:", + Short: "Checks the number of attached NICs. Uses threshold ranges as parameters, e.g. 10:", Run: func(_ *cobra.Command, _ []string) { queryNic() }, @@ -25,8 +25,8 @@ var nicCmd = &cobra.Command{ func init() { rootCmd.AddCommand(nicCmd) - nicCmd.Flags().StringVarP(&nicWarning, "warning", "w", "2:", "Warning threshold (\"less than X available\")") - nicCmd.Flags().StringVarP(&nicCritical, "critical", "c", "1:", "Critical threshold (\"less than X available\")") + nicCmd.Flags().StringVarP(&nicWarning, "warning", "w", "2:", "Warning threshold range") + nicCmd.Flags().StringVarP(&nicCritical, "critical", "c", "1:", "Critical threshold range") } func queryNic() { diff --git a/cmd/temperature.go b/cmd/temperature.go index 815d4d3..c450471 100644 --- a/cmd/temperature.go +++ b/cmd/temperature.go @@ -28,8 +28,8 @@ var temperatureCmd = &cobra.Command{ func init() { rootCmd.AddCommand(temperatureCmd) - temperatureCmd.Flags().StringVarP(&temperatureWarning, "warning", "w", "50", "Warning threshold") - temperatureCmd.Flags().StringVarP(&temperatureCritical, "critical", "c", "60", "Critical threshold") + temperatureCmd.Flags().StringVarP(&temperatureWarning, "warning", "w", "50", "Warning threshold range") + temperatureCmd.Flags().StringVarP(&temperatureCritical, "critical", "c", "60", "Critical threshold range") temperatureCmd.Flags().StringVarP(&temperatureSensor, "sensor", "", "%", "Sensor name filter (supports SQL LIKE pattern)") }